Add source field to News asset
#395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PGijsbers
commented
Nov 21, 2024
| assert ( | ||
| response_json["source"] | ||
| == "https://tailor-network.eu/shaping-the-future-of-ai-within-the-eu/" | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
This is ugly, but black formatting. I hope to change the formatter to a modern release, preferably also ruff instead of black, so don't feel like working around this right now.
While it is the default, I think important information like allowing NULL values is better left explicit.
PGijsbers
force-pushed
the
metadata/news-source
branch
from
65d62fa to
14b5c42
Compare
Taniya-Das
approved these changes
Dec 12, 2024
Collaborator
Taniya-Das
left a comment
Taniya-Das
left a comment
There was a problem hiding this comment.
It looks good to me. Tested with the REST API by adding a source to an existing item, and by creating a new item with a source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Add the
sourceattribute to the News item.How to Test
The unit test is updated. Manual tests can be performed with the REST API.
First, make sure you have a database that's up-to-date with develop (for example, by
clean.shing the data directory, anduping the REST API). Upload a news item. Check out this feature branch, apply the migration, and test with the REST API (can you now add a source to the old item? create a new item with a source?).Checklist
Related Issues