Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Distribution model #470

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

Conversation

Taniya-Das
Copy link
Collaborator

@Taniya-Das Taniya-Das commented Mar 5, 2025

Change

Screenshot from 2025-03-05 16-06-28
Uses #465 to compare implemented model with conceptual model. Attached picture shows missing and extra fields in Distribution model. The model is also verified manually with the conceptual model json.

Only has_computational_requirement needs to be implemented. Rest of the fields already exist.
ComputationalRequirement has common fields with ComputationalAsset, which is being implemented in a separate PR #.
Will add those fields in ComputationalRequirement once they are created.

How to Test

Checklist

  • Tests have been added or updated to reflect the changes, or their absence is explicitly explained.
  • Documentation has been added or updated to reflect the changes, or their absence is explicitly explained.
  • A self-review has been conducted checking:
    • No unintended changes have been committed.
    • The changes in isolation seem reasonable.
    • Anything that may be odd or unintuitive is provided with a GitHub comment explaining it (but consider if this should not be a code comment or in the documentation instead).
  • All CI checks pass before pinging a reviewer, or provide an explanation if they do not.

Related Issues

@Taniya-Das Taniya-Das changed the title add date_modified field Update Distribution model Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant