Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update person #505

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

update person #505

wants to merge 1 commit into from

Conversation

Taniya-Das
Copy link
Collaborator

@Taniya-Das Taniya-Das commented Mar 22, 2025

Change

Updates Person.
Refer to Issue #494
Will add the Alembic migration script once this PR is approved.

How to Test

Test using unit test and spinning docker containers.

Checklist

  • [x ] Tests have been added or updated to reflect the changes, or their absence is explicitly explained.
  • [ x] Documentation has been added or updated to reflect the changes, or their absence is explicitly explained.
  • [x ] A self-review has been conducted checking:
    • No unintended changes have been committed.
    • The changes in isolation seem reasonable.
    • Anything that may be odd or unintuitive is provided with a GitHub comment explaining it (but consider if this should not be a code comment or in the documentation instead).
  • [ x] All CI checks pass before pinging a reviewer, or provide an explanation if they do not.

Related Issues

@Taniya-Das
Copy link
Collaborator Author

Does it make more sense to define member and member_of field in Agent class instead of Organisation and Person respectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant