Skip to content

Conversation

@PGijsbers
Copy link
Contributor

@PGijsbers PGijsbers commented Sep 30, 2025

With the change in #623 I accidentally introduced a bug that would cause an internal server error if the country was None.

Change(s)

Change Type: Fixed

Change Category: Internal

Changelog Entry:
Fix a bug where a location could not be returned if it had an address without a country.

How to Test

Covered by the added test.

Checklist

  • Tests have been added or updated to reflect the changes, or their absence is explicitly explained.
  • Documentation has been added or updated to reflect the changes, or their absence is explicitly explained.
  • A self-review has been conducted checking:
    • No unintended changes have been committed.
    • The changes in isolation seem reasonable.
    • Anything that may be odd or unintuitive is provided with a GitHub comment explaining it (but consider if this should not be a code comment or in the documentation instead).
  • All CI checks pass before pinging a reviewer, or provide an explanation if they do not.
  • The PR title matches the changelog entry's one-line description.

Related Issues

@PGijsbers PGijsbers changed the title Fix: allow country to be empty when returning a location --> Fix a bug where a location could not be returned if it had an address without a country. Sep 30, 2025
@PGijsbers PGijsbers changed the title --> Fix a bug where a location could not be returned if it had an address without a country. Fix a bug where a location could not be returned if it had an address without a country. Sep 30, 2025
Copy link
Collaborator

@Taniya-Das Taniya-Das left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PGijsbers PGijsbers merged commit 9e2e286 into develop Oct 2, 2025
1 check passed
@PGijsbers PGijsbers deleted the fix-empty-country branch October 2, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants