-
Notifications
You must be signed in to change notification settings - Fork 209
Integration figama #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Integration figama #311
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
WalkthroughThe changes add three new public REST API function definitions to the Figma backend's functions JSON. These new endpoints provide access to retrieve comments, image fills, and component sets from Figma files. Each function is fully specified with HTTP method, endpoint path, required parameters, and descriptions. No existing functions were modified or removed. Changes
Possibly related issues
Poem
π Recent review detailsConfiguration used: CodeRabbit UI π Files selected for processing (1)
π§ Files skipped from review as they are similar to previous changes (1)
β° Context from checks skipped due to timeout of 90000ms (3)
πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
π§Ή Nitpick comments (1)
backend/apps/figma/functions.json (1)
591-636
: Verify component-sets endpoint and naming
The newFIGMA__GET_FILE_COMPONENT_SETS
uses/v1/files/{file_key}/component_sets
, but the official Figma API exposes components via/v1/files/{file_key}/components
. Please confirm that/component_sets
is a valid endpoint.
Also consider renaming toFIGMA__GET_FILE_COMPONENTS
for consistency with existing naming conventions.
π Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
π Files selected for processing (1)
backend/apps/figma/functions.json
(1 hunks)
β° Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Format & Lint
- GitHub Check: Format, Lint, and Test
- GitHub Check: Compose Tests
π Additional comments (3)
backend/apps/figma/functions.json (3)
364-410
: Well-formed GET_COMMENTS endpoint
The newFIGMA__GET_COMMENTS
definition correctly follows the established pattern (HTTP method, path parameters, visibility, andadditionalProperties: false
). Itβs properly tagged and documented.
545-590
: GET_IMAGE_FILLS looks good
TheFIGMA__GET_IMAGE_FILLS
endpoint on/v1/files/{file_key}/images
is correctly declared, with required path parameters and no unexpected properties.
364-636
: PR summary discrepancy: missing ACTIVITY_LOGS
The PR description mentions aFIGMA__GET_ACTIVITY_LOGS
function, but no such declaration appears in this JSON. Please clarify whether that integration was omitted or should be added here.Likely an incorrect or invalid review comment.
π·οΈ Ticket
issue
π Description
1. FIGMA GET COMMENTS IN A FILE
Function Name:
FIGMA__GET_COMMENTS
2. FIGMA GET STYLE
Function Name:
FIGMA__GET_FILE_NODES
(with focus on style nodes)3. FIGMA GET VERSIONS OF A FILE
Function Name:
FIGMA__GET_FILE_VERSIONS
4. FIGMA GET ACTIVITY LOGS
Function Name:
FIGMA__GET_ACTIVITY_LOGS
5. FIGMA GET IMAGE FILLS
Function Name:
FIGMA__GET_IMAGE_FILLS
6. FIGMA GET COMPONENT
Function Name:
FIGMA__GET_FILE_NODES
(with focus on component nodes)7. FIGMA GET FILE COMPONENT SETS
Function Name:
FIGMA__GET_FILE_COMPONENT_SETS
πΈ Screenshots (if applicable)
notion link has Screenshots
β Checklist
Summary by CodeRabbit
Summary by CodeRabbit