Skip to content

Replace app title link with 'Go to App' button on configuration page #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Keerthi421
Copy link

@Keerthi421 Keerthi421 commented May 5, 2025

🏷️ Ticket
Fixes #308

πŸ“ Description
This PR addresses the issue where the app title on the app configuration page is a clickable link, while app titles on other pages are not links, causing inconsistent UX.
Changes made:
Removed the link from the app title in the app configuration page
Added a dedicated "Go to App" button next to the add account form
Improved UI consistency to match how app titles are displayed on other pages

βœ… Checklist

  • I have signed the Contributor License Agreement (CLA) and read the contributing guide (required)
  • I have linked this PR to an issue or a ticket (required)
  • I have updated the documentation related to my change if needed
  • I have updated the tests accordingly (required for a bug fix or a new feature)
  • All checks on CI passed

Summary by CodeRabbit

  • New Features

    • Introduced a "Go to App" button with an outline style and small size, placed next to the Add Account form for easier navigation.
  • Style

    • Updated layout to display the "Go to App" button and Add Account form side by side with improved spacing.
    • The app name heading is no longer a clickable link.

Copy link

vercel bot commented May 5, 2025

@Keerthi421 is attempting to deploy a commit to the Proxy Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented May 5, 2025

Walkthrough

The change modifies the app configuration page by removing the clickable link from the app's display name heading. Instead, a new "Go to App" button is introduced next to the AddAccountForm component. This button provides navigation to the app's page, replicating the previous link functionality but as a distinct button. The layout now uses a horizontal flex container to group the "Go to App" button and the account form with appropriate spacing. No changes are made to the exported or public entities.

Changes

File(s) Change Summary
frontend/src/app/appconfigs/[appName]/page.tsx Removed link from app name heading; added "Go to App" button next to AddAccountForm in flex row.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AppConfigPage
    participant AppPage

    User->>AppConfigPage: Visit app configuration page
    AppConfigPage-->>User: Display app name (not a link), AddAccountForm, and "Go to App" button
    User->>AppConfigPage: Click "Go to App" button
    AppConfigPage->>AppPage: Navigate to app page
Loading

Assessment against linked issues

Objective Addressed Explanation
Remove link from app title and add "Go to App" button (#308) βœ…

Poem

A button now sits where the link used to be,
"Go to App" it says, with joy and with glee.
The title stands proud, no longer a gate,
While accounts and buttons together look great.
In the land of configs, the UX feels rightβ€”
A rabbit approves, with a hop of delight! πŸ‡βœ¨


πŸ“œ Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 7effa02 and d7e1e61.

πŸ“’ Files selected for processing (1)
  • frontend/src/app/appconfigs/[appName]/page.tsx (1 hunks)
πŸ”‡ Additional comments (2)
frontend/src/app/appconfigs/[appName]/page.tsx (2)

274-274: App title is correctly converted to non-clickable text

The app title is now displayed as a standard heading without a link wrapper, which brings consistency with other pages where app titles aren't links.


278-298: Excellent implementation of the "Go to App" button

The new layout looks well-structured with a flex container that groups the "Go to App" button alongside the AddAccountForm. The button provides clear navigation to the app page while maintaining the same functionality that was previously on the title link. The conditional rendering ensures the button only appears when app data is available.

This implementation improves UI consistency and accessibility by providing an explicit navigation button rather than relying on a clickable heading.

✨ Finishing Touches
  • πŸ“ Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dev-aipolabs
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App configuration page, replace the app link with a "Go to App" button
2 participants