use prod env for default team

airbnb · Feb 28, 2024 · 9255b3c · 9255b3c
1 parent 34dc28a
commit 9255b3c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 22 deletions.
diff --git a/api/py/ai/chronon/repo/run.py b/api/py/ai/chronon/repo/run.py
@@ -311,9 +311,10 @@ def set_runtime_env(args):
                 environment["production_team_env"] = (
                     teams_json[team].get("production", {}).get(effective_mode, {})
                 )
+                # For default env we can alwasy use production env.
                 environment["default_env"] = (
                     teams_json.get("default", {})
-                    .get(context, {})
+                    .get("production", {})
                     .get(effective_mode, {})
                 )
                 environment["cli_args"]["CHRONON_CONF_PATH"] = conf_path

diff --git a/api/py/test/sample/teams.json b/api/py/test/sample/teams.json
@@ -32,26 +32,6 @@
                 "EXECUTOR_MEMORY": "4G",
                 "PARALLELISM": "16"
             }
-        },
-        "dev": {
-            "backfill" : {
-                "EXECUTOR_CORES": "1",
-                "DRIVER_MEMORY": "15G",
-                "EXECUTOR_MEMORY": "16G",
-                "PARALLELISM": "4000",
-                "MAX_EXECUTORS": "1000"
-            },
-            "upload" : {
-                "EXECUTOR_CORES": "1",
-                "EXECUTOR_MEMORY": "8G",
-                "PARALLELISM": "1000",
-                "MAX_EXECUTORS": "1000"
-            },
-            "streaming" : {
-                "EXECUTOR_CORES": "2",
-                "EXECUTOR_MEMORY": "4G",
-                "PARALLELISM": "16"
-            }
         }
     },
     "sample_team": {

diff --git a/api/py/test/test_run.py b/api/py/test/test_run.py
@@ -125,7 +125,7 @@ def test_environment(teams_json, repo, parser, test_conf_location):
     # from team dev env.
     assert os.environ['DRIVER_MEMORY'] == '30G'
     # from default dev env.
-    assert os.environ['EXECUTOR_MEMORY'] == '16G'
+    assert os.environ['EXECUTOR_MEMORY'] == '8G'
 
     # Check conf set environment overrides most.
     reset_env(default_environment)