Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE#3032 #3072

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

ISSUE#3032 #3072

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b42393
Descriptive commit message
JASH9898567 Dec 15, 2024
af74cec
Update README.md
JASH9898567 Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3183,6 +3183,11 @@ Other Style Guides
inventorOf,
);

//good
export const MY_EXPORTED_FUNCTION = () => {
return 'hello function';
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the indentation on this is incorrect, and there's no reason for this to be an arrow function, so it shouldn't be:

Suggested change
export const MY_EXPORTED_FUNCTION = () => {
return 'hello function';
};
export function MY_EXPORTED_FUNCTION() {
return 'hello function';
};

but also this example has nothing to do with dangling commas, which is the section you've placed it in

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this still doesn't make any sense in this section.


// good (note that a comma must not appear after a "rest" element)
createHero(
firstName,
Expand Down Expand Up @@ -3546,7 +3551,7 @@ Other Style Guides
const PRIVATE_VARIABLE = 'should not be unnecessarily uppercased within a file';

// bad
export const THING_TO_BE_CHANGED = 'should obviously not be uppercased';
export const MY_CONSTANT = 'should obviously not be uppercased';

// bad
export let REASSIGNABLE_VARIABLE = 'do not use let with uppercase variables';
Expand Down
Loading