[graphApi] add non-identity edge annotations with ancestor inheritence#84
Open
pbibra wants to merge 2 commits into
Open
[graphApi] add non-identity edge annotations with ancestor inheritence#84pbibra wants to merge 2 commits into
pbibra wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_annotation: trueboolean toedge_metadata_tag_mappingfields inGraphConfig. Annotation fields are excluded from edge identity (not part of metadata orgenerateKey) so they never split otherwise identical edges.Edge.annotations(Map<String, Set<String>>), accumulating distinct values across observations of the same logical edge.addObservation(Map<String,String>)replacesincrementObservedCount()asthe single call site, combining count increment and annotation merge.
GraphConfig.resolveAnnotationsForSpan, which walks the parent chain to find the nearest ancestor where all configured keys fully resolve. Results are memoized so each span's chain is walked at most once. All annotation fields currently inherit from ancestors by default. A futureinherit_from_ancestorflag or equivalent onTagConfigcould gate this per field.GraphBuilder.traverseAndBuildGraph— only spans that produce edges are walked, keeping it lazy.Requirements