fix: decode the post.uuid before comparing it with other uuids#587
Open
dmaljovec wants to merge 2 commits intoairbnb:masterfrom
Open
fix: decode the post.uuid before comparing it with other uuids#587dmaljovec wants to merge 2 commits intoairbnb:masterfrom
dmaljovec wants to merge 2 commits intoairbnb:masterfrom
Conversation
naoyak
approved these changes
Aug 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
We encountered a problem where the
uuidof our posts looks like a hex string, but it is being compared withbyteson thekr_dirandkpobjects. This bit of logic ensures we are comparing apples to apples by forcing thepost.uuidto be decoded if it is a hex string and coercing it to abytesobject as comparing astrto abyteswill never result in equality.Why?
The reason for this change, is that any update to our knowledge repo becomes a reindex of all posts which means our consumers have to wait to see their new posts. This should drastically reduce the amount of work per reindex operation.
Description of changeset:
post.uuidis compared to existing data.Test Plan:
update_indexthat gets triggered does not rewrite everything.