Skip to content

Conversation

valgaze
Copy link

@valgaze valgaze commented Feb 15, 2018

If approved, resolves #263

- [ ] You now can clone or download react-sketchapp to the directory from the step above by copying the following command into your terminal:

```sh
git clone https://github.com/airbnb/react-sketchapp.git
Copy link
Collaborator

@mathieudutour mathieudutour Feb 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a bit going against the instructions given in each examples: curl each example separately so the people are not scared by all the other files

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it does break the convention slightly, however, my sense is that just to get them up and running it's a much cleaner approach to pull in the entire repo. Each of the individual examples have a line that say "Download the example or clone the repo" and the distinction might be lost on new folks. If they run through the instructions they'll probably pick up how to navigate with the command line and can jump off from there.

Then individual clone commands with pipes to things like | tar -xz --strip=2 or curl would make more sense

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathieudutour What are you thinking?

@mathieudutour
Copy link
Collaborator

Thanks for the docs! I'm not sure about the "clone everything" approach tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(docs) Add a "slowstart"

2 participants