Skip to content

convex domain for ball #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ducoffeM
Copy link
Collaborator

  • the clone method was not working for ball due to the use of ConvexTypeDomain and not convertir the name ball to the associated ConvexTypeDomain object.
  • tests in test_clone are covering the different domains
  • in backward_layers relu_ get_upper and get_lower were not using convex_domain

@ducoffeM ducoffeM force-pushed the convex_domain_ball branch from c1428bf to 8407fb3 Compare April 19, 2023 12:40
"p",
[2, np.inf],
)
def test_convert_1D(p, n, method, mode, floatx, helpers):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beware, this function is already defined in the same file. You should modify the name (something like test_convert_1D_ball ?)

@ducoffeM ducoffeM force-pushed the convex_domain_ball branch 2 times, most recently from f3ffec7 to d81172d Compare April 20, 2023 13:44
@ducoffeM ducoffeM force-pushed the convex_domain_ball branch from d81172d to af68477 Compare April 21, 2023 07:18
@nhuet
Copy link
Contributor

nhuet commented Jun 19, 2023

I rebased the branch on my fork so that

  • I use the new perturbation domain classes instead of old ConvexDomainType
  • I fix the use of get_upper/get_lower in all places where they are called to specify each time the proper perturbation domain
  • I use the new fixtures in test_clone_ball
  • I use the new default decimal for assert_output_properties_ball, and no more "name" arg (o be consistent with other assert functions)
  • I use an appropriate radius and ball center (it seems to me that the previous radius was actually the diameter).

But now the test is failing, either because i failed using appropriate inputs for the decomon/keras models, or because the bounds computation for ball domain has issues. (Probably the first point :D)

You can see this work on my branch convex_domain_ball on my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants