Skip to content

Conversation

@aaronsteers
Copy link
Contributor

@aaronsteers aaronsteers commented May 20, 2024

A fix for #244.

This is smaller scope than:

In that PR, we modify the failover type to be object/JSON/VARIANT for cases of anyOf(string, object). In this case, we don't change anything except to make sure that the expected exception is raised - and this triggers the expected failsafe behavior, without changing it.

@aaronsteers aaronsteers requested a review from bindipankhudi May 20, 2024 21:16
@aaronsteers aaronsteers changed the title Fix: Resolve error TypeError "unhashable type list" (2) Fix: Resolve error TypeError "unhashable type list" (2nd pass) May 20, 2024
Copy link
Contributor

@bindipankhudi bindipankhudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

@aaronsteers
Copy link
Contributor Author

Noting here for follow-up, I'm not getting consistent rendering across database platforms when I try to validate records converted from object type to string type. The differences are minor, but enough to break tests significantly.

E.g. one database will write the string '{"nested_column": "nested_value"}' and another will write '{"nested_column":"nested_value"}'. I'm simplifying test inputs so we can prioritize the known fix to type resolution itself, and we can come back to this in:

@aaronsteers aaronsteers enabled auto-merge (squash) May 21, 2024 18:12
@aaronsteers aaronsteers merged commit bcfed96 into main May 21, 2024
@aaronsteers aaronsteers deleted the aj/fix/issue-244/typeerror-unhashable-type-list-2 branch May 21, 2024 18:21
@aaronsteers aaronsteers linked an issue May 23, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

source-zendesk-support: TypeError: unhashable type: 'list'

3 participants