Skip to content

feat(caches): add create_source_tables method to CacheBase class (do not merge)#631

Merged
Aaron ("AJ") Steers (aaronsteers) merged 4 commits intomainfrom
devin/1742593420-add-write-source-tables
Mar 22, 2025
Merged

feat(caches): add create_source_tables method to CacheBase class (do not merge)#631
Aaron ("AJ") Steers (aaronsteers) merged 4 commits intomainfrom
devin/1742593420-add-write-source-tables

Conversation

@devin-ai-integration
Copy link
Contributor

Add create_source_tables method to CacheBase

This PR adds a new method to PyAirbyte's CacheBase class called create_source_tables(source: Source, streams: Literal['*'] | list[str] | None = None) that creates tables in the cache for the provided source if they do not exist already, based upon the Source's catalog.

If streams input is not provided, it uses the Source's selected_streams or "*" if neither is set.

Requested by

Aaron ("AJ") Steers (aj@airbyte.io)

Link to Devin run

https://app.devin.ai/sessions/6e72c5605a6a466bbef1fe26531ab85d

Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

Original prompt from Aaron:

@Devin - Can you add a method to PyAirbyte's `CacheBase` class called "write_source_tables(source: Source, streams: Literal['*'] | list[str] | None = None)" and that method would create tables in the cache for the provided source if they do not exist already, based upon the Source's catalog? If streams input is not provided, we would use the Sources `selected_streams` or "*" if neither is set.*

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a small test for this somewhere?

@aaronsteers Aaron ("AJ") Steers (aaronsteers) marked this pull request as ready for review March 22, 2025 01:56
@aaronsteers Aaron ("AJ") Steers (aaronsteers) merged commit 753c2ac into main Mar 22, 2025
18 of 19 checks passed
@aaronsteers Aaron ("AJ") Steers (aaronsteers) deleted the devin/1742593420-add-write-source-tables branch March 22, 2025 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant