Skip to content

ci: fix failing Python 3.12 tests #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 22, 2025

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Fixing CI for PR #599 by:

  • Re-locked the lock file
  • Commented out Python 3.12 from the pytest matrix
  • Added skip marker for source-pokeapi tests that fail with Python 3.12 due to the API blocking bots/CI runners

Requested by: Aaron ("AJ") Steers ([email protected])
Link to Devin run: https://app.devin.ai/sessions/3c0f38bcc54447919e01bf2bead1f251

Copy link
Contributor Author

🤖 Devin AI Engineer

Original prompt from Aaron:

@Devin - Can you help me get CI into a good place with this PyAirbyte PR: <https://github.com/airbytehq/PyAirbyte/pull/599>

You can start by updating the branch from main, then re-lock the lock file. Then, comment out Python 3.12 from the pytest matrix, with a note that certain tests don't work in 3.12, even though PyAirbyte itself does work on 3.12.

After that, make a list of all tests failing in CI. Then add a pytest 'skip' operation for any tests that fail in CI. I believe source-pokeapi is failing now due to the service being blocked for CI runners (basically CAPTCHA) so we will skip anything that tests source-pokeapi with a note that the pokeAPI interface is blocked for bots.

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Co-Authored-By: Aaron <AJ> Steers <[email protected]>
@aaronsteers aaronsteers merged commit 0416ade into aj/update-python-requirement Mar 22, 2025
16 checks passed
@aaronsteers aaronsteers deleted the devin/1742599734-ci-fixes branch March 22, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant