Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add explicit docker volume mapping (resolves permission denied errors); fix: remove 'cdk:low-code' logic with false-positives for manifest-only connector detection; feat: add option to auto-print full log file text, enabled by default in CI environments #637

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
grant read to all users
aaronsteers committed Mar 25, 2025
commit 95e63fa9ad5dddd0174bd3493a1e1c55773a1a9e
2 changes: 1 addition & 1 deletion airbyte/_executors/util.py
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@

from airbyte import exceptions as exc
from airbyte._executors.declarative import DeclarativeExecutor
from airbyte._executors.docker import DockerExecutor, DEFAULT_AIRBYTE_CONTAINER_TEMP_DIR
from airbyte._executors.docker import DEFAULT_AIRBYTE_CONTAINER_TEMP_DIR, DockerExecutor
from airbyte._executors.local import PathExecutor
from airbyte._executors.python import VenvExecutor
from airbyte._util.meta import which
4 changes: 4 additions & 0 deletions airbyte/_util/temp_files.py
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@
from __future__ import annotations

import json
import stat
import tempfile
import time
import warnings
@@ -36,6 +37,9 @@ def as_temp_files(files_contents: list[dict | str]) -> Generator[list[str], Any,
json.dumps(content) if isinstance(content, dict) else content,
)
temp_file.flush()
# Grant "read" permission to all users
Path(temp_file.name).chmod(stat.S_IRUSR | stat.S_IRGRP | stat.S_IROTH)

# Don't close the file yet (breaks Windows)
# temp_file.close()
temp_files.append(temp_file)
Loading