fix: use stderr for log and progress prints #720
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR redirects log and informational print statements from stdout to stderr to improve output separation. This ensures that actual data output remains clean on stdout while logging messages are sent to stderr.
- Redirected warning and status messages to stderr across multiple modules
- Modified print_config_spec method to accept a stderr parameter for output control
- Added input validation to prevent conflicting output destinations
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| airbyte/sources/base.py | Updated warning and log messages to use stderr, removed print_config_spec method |
| airbyte/cli.py | Modified connector validation output to use stderr |
| airbyte/_executors/util.py | Redirected executable location message to stderr |
| airbyte/_executors/python.py | Updated installation and error messages to use stderr |
| airbyte/_connector_base.py | Enhanced print_config_spec with stderr parameter and redirected various status messages |
|
/format-fix |
📝 WalkthroughWalkthroughThe changes systematically redirect informational and error messages from standard output to standard error across several modules. Method signatures and imports are updated to support this, particularly in configuration specification printing. Additionally, the Changes
Suggested labels
By the way, would you like to consider documenting this new stderr output behavior in the user-facing CLI documentation as well, wdyt? 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
🔇 Additional comments (3)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
/fix-pr
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Testing This PyAirbyte VersionYou can test this version of PyAirbyte using the following: # Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/airbytehq/PyAirbyte.git@aj/fix/use-stderr-for-log-prints' pyairbyte --help
# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/airbytehq/PyAirbyte.git@aj/fix/use-stderr-for-log-prints'Helpful ResourcesPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
Community SupportQuestions? Join the #pyairbyte channel in our Slack workspace. |
aaronsteers
changed the title
|
Tested successfully by filtering out all STDERR messages: Verified that... before: very noisy. This is important because when we run in MCP mode, extraneous prints to STDOUT are picked up as seemingly erroneous JSON lines. |
1 participant
Summary by CodeRabbit
New Features
Refactor
Important
Auto-merge enabled.
This PR is set to merge automatically when all requirements are met.