test: xfail cloud tests with permission errors #765
Conversation
- Add @pytest.mark.xfail to test_translate_cloud_job_to_sql_cache for Snowflake and BigQuery variants - These tests fail with Status 403 permission errors unrelated to code changes - Add dummy comment to pyproject.toml to trigger CI testing - Requested by @aaronsteers for cloud test investigation Co-Authored-By: AJ Steers <[email protected]>
Original prompt from AJ Steers |
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Testing This PyAirbyte VersionYou can test this version of PyAirbyte using the following: # Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1756312930-xfail-cloud-tests' pyairbyte --help
# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1756312930-xfail-cloud-tests'Helpful ResourcesPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
Community SupportQuestions? Join the #pyairbyte channel in our Slack workspace. |
aaronsteers
changed the title
📝 WalkthroughWalkthroughA comment was added in pyproject.toml to trigger CI. One test in tests/integration_tests/cloud/test_cloud_sql_reads.py was marked xfail due to expected 403 permission errors. No production code or control flow changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Would you like to also annotate the xfail with a link to the failing CI job or issue for traceability, wdyt? ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/integration_tests/cloud/test_cloud_sql_reads.py (1)
96-98: Scope xfail to only the failing params (Snowflake/BigQuery) and reference issue #764?Marking the whole test xfail can hide unrelated regressions. Would you move xfail onto the two affected pytest.param cases and keep it non-strict to avoid CI noise, wdyt?
-@pytest.mark.xfail( - reason="Cloud API permission errors: Status 403 - Caller does not have required WORKSPACE_READER permissions. Unrelated to code changes." -)Outside the selected lines, update the two params like this:
pytest.param( "c7b4d838-a612-495a-9d91-a14e477add51", SnowflakeCache, id="Faker->Snowflake", marks=pytest.mark.xfail(reason="403 WORKSPACE_READER missing; tracked in #764"), ), pytest.param( "0e1d6b32-b8e3-4b68-91a3-3a314599c782", BigQueryCache, id="Faker->BigQuery", marks=pytest.mark.xfail(reason="403 WORKSPACE_READER missing; tracked in #764"), ),
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
pyproject.toml(1 hunks)tests/integration_tests/cloud/test_cloud_sql_reads.py(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Pytest (All, Python 3.11, Ubuntu)
- GitHub Check: Pytest (All, Python 3.11, Windows)
- GitHub Check: Pytest (All, Python 3.10, Windows)
- GitHub Check: Pytest (All, Python 3.10, Ubuntu)
- GitHub Check: Pytest (No Creds)
- GitHub Check: Pytest (Fast)
🔇 Additional comments (1)
pyproject.toml (1)
10-10: No-op CI nudge looks fine.This comment won’t affect packaging or dynamic versioning; safe to leave in the draft and drop before merge, wdyt?
PyTest Results (Full)364 tests ±0 348 ✅ - 2 18m 43s ⏱️ +48s Results for commit 39ecc5c. ± Comparison against base commit be50b70. This pull request skips 2 tests. |
1 participant
Summary
This PR adds
@pytest.mark.xfailmarkers to cloud integration tests that are failing with Status 403 permission errors. The tests fail because the API credentials don't have requiredWORKSPACE_READERpermissions to access Airbyte Cloud job information. This prevents CI failures while the underlying permission issues are resolved in issue #764.Changes:
test_translate_cloud_job_to_sql_cachefor Snowflake and BigQuery variantspyproject.tomlto trigger CIReview & Testing Checklist for Human
Notes
Requested by: @aaronsteers for cloud test investigation
Session: https://app.devin.ai/sessions/55544c0ad1d84984b252650d469f4f9b
Summary by CodeRabbit
Chores
Tests
Important
Auto-merge enabled.
This PR is set to merge automatically when all requirements are met.