-
Notifications
You must be signed in to change notification settings - Fork 67
chore(deps): Relax uv
version requirement for broader compatibility with other tools
#777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For the current use of `uv`, it's not necessary to constrain the package version to ^0.5.0. The commands used in PyAirbyte: `uv venv` and `uv pip install` are working as well up to the current version (0.8.15) and are not likely to change up to 0.9.0. I'm trying to use PyAirbyte with Prefect and Prefect [requires](https://github.com/PrefectHQ/prefect/blob/main/pyproject.toml#L84) 'uv>=0.6.0'. With this constraint it's impossible to have both packages installed at the same time.
📝 WalkthroughWalkthroughUpdated the uv dependency constraint in pyproject.toml from ^0.5.0 to >=0.5.0,<0.9.0 under [tool.poetry.dependencies]. No other files or changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Would you like to add a brief note in the changelog documenting the widened uv compatibility range, wdyt? Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Pre-merge checks (3 passed)✅ Passed checks (3 passed)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyproject.toml (1)
56-56
: Optional: align lower bound to Prefect and add a tiny CI matrix to guard future bumps.
- If Prefect truly requires uv>=0.6.0, do we want to tighten our floor to 0.6.0 to reflect that reality, or keep 0.5.0 for broader compatibility, wdyt?
- Consider a smoke job that installs with uv at {latest 0.5.x, latest 0.8.x} and exercises the two commands. This will catch regressions early.
If you prefer the stricter floor, here’s the minimal diff:
-uv = ">=0.5.0,<0.9.0" +uv = ">=0.6.0,<0.9.0"Also, after merging, shall we refresh the lockfile to capture the widened range?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
poetry.lock
is excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Pytest (No Creds)
- GitHub Check: Pytest (Fast)
🔇 Additional comments (2)
pyproject.toml (2)
56-56
: Loosened uv range unblocks Prefect while keeping a safety ceiling — LGTM.Allowing uv >=0.5.0,<0.9.0 matches the stated CLI-only usage and should resolve the Prefect co-install conflict without overexposing to potential 0.9+ breaking changes, wdyt?
56-56
: UV CLI usage verified
Onlyuv venv
(airbyte/validate.py) anduv pip install
(airbyte/validate.py & airbyte/_executors/python.py) calls exist—no otheruv
subcommands detected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bosper351 - This looks great. Thanks for contributing. 🙏
/test-pr
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Testing This PyAirbyte VersionYou can test this version of PyAirbyte using the following: # Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/airbytehq/PyAirbyte.git@relax-uv-requirement' pyairbyte --help
# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/airbytehq/PyAirbyte.git@relax-uv-requirement' Helpful ResourcesPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
Community SupportQuestions? Join the #pyairbyte channel in our Slack workspace. |
uv
version requirement for broader compatibility with other tools
/test-pr
|
@bosper351 - This is merged! Thanks again! Release should happen shortly, but I can't give a firm ETA because there are several unreleased updates pending right now on |
For the current use of
uv
, it's not necessary to constrain the package version to ^0.5.0. The commands used in PyAirbyte:uv venv
anduv pip install
are working as well up to the current version (0.8.15) and are not likely to change up to 0.9.0.I'm trying to use PyAirbyte with Prefect and Prefect requires 'uv>=0.6.0'. With this constraint it's impossible to have both packages installed at the same time.
Summary by CodeRabbit