chore: bump to poetry 2.2.0 #795
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Testing This PyAirbyte VersionYou can test this version of PyAirbyte using the following: # Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/airbytehq/PyAirbyte.git@aj/bump-top-poetry-2.2.0' pyairbyte --help
# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/airbytehq/PyAirbyte.git@aj/bump-top-poetry-2.2.0'Helpful ResourcesPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
Community SupportQuestions? Join the #pyairbyte channel in our Slack workspace. |
|
Warning Rate limit exceeded@aaronsteers has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 49 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAll affected GitHub Actions workflows update the Gr1N/setup-poetry@v9 input poetry-version from "2.0.1" to "2.2.0". No other steps, conditions, or control flow were modified. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Would you like to add a brief note in the PR description about verifying Poetry 2.2.x compatibility with your lockfile resolution to aid reviewers, wdyt? Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (11)
.github/workflows/fix-pr-command.yml (2)
100-104: Replace deprecated ::set-output with GITHUB_OUTPUT.This step still uses the deprecated command; switch to file-based output to satisfy actionlint. Wdyt?
Apply:
- run: | - git diff --quiet && echo "No changes to commit" || echo "::set-output name=changes::true" + run: | + if git diff --quiet; then + echo "No changes to commit" + else + echo "changes=true" >> "$GITHUB_OUTPUT" + fi
124-129: Same here: remove ::set-output in second diff check.Mirror the fix for the second “unsafe” pass. Wdyt?
- run: | - git diff --quiet && echo "No changes to commit" || echo "::set-output name=changes::true" + run: | + if git diff --quiet; then + echo "No changes to commit" + else + echo "changes=true" >> "$GITHUB_OUTPUT" + fi.github/workflows/autofix.yml (1)
22-25: Poetry 2.2.0 bump LGTM; minor nit on commit message.Step runs Ruff formatter but commit message says “Format code with black”. Consider updating the message for accuracy, wdyt?
- git diff-index --quiet HEAD || git commit -m "Format code with black" + git diff-index --quiet HEAD || git commit -m "Format code with ruff format".github/workflows/python_lint.yml (3)
28-33: Duplicate Poetry setup — can we drop one to save time?In ruff-lint-check, Poetry is set up twice (Lines 21–24 and 29–32). Removing one should speed CI slightly. Same pattern exists in mypy-check (Lines 69–72 and 77–80). Wdyt?
69-72: Poetry 2.2.0 bump LGTM; consider caching to speed installs.Optional: add dependency caching (e.g., actions/cache keyed on poetry.lock + OS + py) to cut install time. Wdyt?
77-80: Second Poetry setup in mypy-check likely redundant.Same dedupe suggestion as above. Wdyt?
.github/workflows/python_pytest.yml (2)
39-42: Two Poetry setup steps in pytest-fast — remove one?You set Poetry twice (Lines 31–34 and 39–42). Dropping one should shorten CI. Wdyt?
104-107: Duplicate Poetry setup in pytest-no-creds.Same dedupe opportunity as above. Wdyt?
.github/workflows/poetry-lock-command.yml (3)
100-103: Replace deprecated ::set-output with GITHUB_OUTPUT.Modernize to avoid actionlint failures. Wdyt?
- run: | - git diff --quiet && echo "No changes to commit" || echo "::set-output name=changes::true" + run: | + if git diff --quiet; then + echo "No changes to commit" + else + echo "changes=true" >> "$GITHUB_OUTPUT" + fi
129-136: Fix reference to undefined step idgit-diff-2.There’s no step with id
git-diff-2in this workflow, so this condition never resolves. Either add a second diff step or remove this clause. Wdyt?- if: steps.git-diff.outputs.changes != 'true' && steps.git-diff-2.outputs.changes != 'true' + if: steps.git-diff.outputs.changes != 'true'
106-113: Backticks in commit message trigger unintended command substitution.
git commit -m "Auto-commit \poetry lock` changes"executespoetry lock` inside the message. Use single quotes (or escape backticks) to avoid shell substitution. Wdyt?- git commit -m "Auto-commit `poetry lock` changes" + git commit -m 'Auto-commit `poetry lock` changes'
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
poetry.lockis excluded by!**/*.lock
📒 Files selected for processing (8)
.github/workflows/autofix.yml(1 hunks).github/workflows/fix-pr-command.yml(1 hunks).github/workflows/poetry-lock-command.yml(1 hunks).github/workflows/pydoc_preview.yml(1 hunks).github/workflows/pydoc_publish.yml(1 hunks).github/workflows/python_lint.yml(3 hunks).github/workflows/python_pytest.yml(4 hunks).github/workflows/test-pr-command.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Pytest (All, Python 3.11, Ubuntu)
- GitHub Check: Pytest (All, Python 3.10, Ubuntu)
- GitHub Check: Pytest (No Creds)
- GitHub Check: Pytest (Fast)
🔇 Additional comments (11)
.github/workflows/pydoc_publish.yml (1)
41-44: Poetry 2.2.0 bump looks good; please confirm lock compatibility.No workflow logic change; just verify CI pulls Poetry 2.2.0 successfully and that no
poetry lockformat diffs are introduced compared to 2.0.1, especially for contributors using older local Poetry. Wdyt?.github/workflows/fix-pr-command.yml (1)
84-87: Poetry 2.2.0 bump LGTM.Thanks for keeping all workflows consistent. Wdyt?
.github/workflows/python_lint.yml (2)
21-24: Bump to Poetry 2.2.0 looks good.No functional change; consistent with other workflows. Wdyt?
51-54: Poetry 2.2.0 bump LGTM here as well.All good. Wdyt?
.github/workflows/pydoc_preview.yml (1)
24-27: Poetry 2.2.0 bump LGTM.No other changes; docs generation should be unaffected. Wdyt?
.github/workflows/python_pytest.yml (4)
31-34: Poetry 2.2.0 bump LGTM (pytest-fast).Looks consistent with the matrix. Wdyt?
96-99: Poetry 2.2.0 bump LGTM (pytest-no-creds).All good. Wdyt?
178-181: Poetry 2.2.0 bump LGTM (pytest all).No other logic changes. Wdyt?
251-254: Poetry 2.2.0 bump LGTM (dep analysis).All good. Wdyt?
.github/workflows/poetry-lock-command.yml (1)
87-90: Poetry 2.2.0 bump LGTM.Thanks for aligning lock workflow too. Wdyt?
.github/workflows/test-pr-command.yml (1)
116-119: Poetry 2.2.0 bump LGTM.No other step changes; on-demand tests should behave the same. Wdyt?
1 participant
Summary by CodeRabbit
Important
Auto-merge enabled.
This PR is set to merge automatically when all requirements are met.