-
Notifications
You must be signed in to change notification settings - Fork 67
feat: add cloud cleanup script for stale integration test artifacts #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add limit, offset, and include_deleted parameters to list_connections, list_sources, and list_destinations - Update underlying api_util functions to accept and pass through pagination parameters - Maintain backward compatibility with optional parameters and sensible defaults - Update docstrings to document new pagination parameters - Add noqa comments to suppress PLR0913 linting warnings for necessary parameter count Co-Authored-By: AJ Steers <[email protected]>
- Scans source code for hardcoded UUIDs to exempt from cleanup - Lists and deletes stale connections, sources, and destinations - Defaults to dry-run mode for safety - Uses existing PyAirbyte cloud operations and authentication - Includes poe task for easy execution Co-Authored-By: AJ Steers <[email protected]>
Original prompt from AJ Steers
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Testing This PyAirbyte VersionYou can test this version of PyAirbyte using the following: # Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1758315185-cloud-cleanup-script' pyairbyte --help
# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1758315185-cloud-cleanup-script' Helpful ResourcesPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
Community SupportQuestions? Join the #pyairbyte channel in our Slack workspace. |
- Regenerated poetry.lock to match current pyproject.toml changes - Resolves Poetry version conflict (2.2.0 vs 2.0.1) - Fixes 'pyproject.toml changed significantly' error - All imports and script functionality verified locally Co-Authored-By: AJ Steers <[email protected]>
- Removed direct six dependency (DEP002 violation) - Six still available as transitive dependency via python-dateutil - Verified locally: deptry check passes and script works correctly Co-Authored-By: AJ Steers <[email protected]>
PyTest Results (Full)364 tests ±0 346 ✅ ±0 21m 10s ⏱️ +32s For more details on these failures, see this check. Results for commit 1e0fcf2. ± Comparison against base commit 31c8f15. ♻️ This comment has been updated with latest results. |
…o devin/1758315185-cloud-cleanup-script
This PR targets the following PR:
name
attribute for cloud objects:CloudConnection
,CloudSource
, andCloudDestination
#782feat: add cloud cleanup script for stale integration test artifacts
Summary
Adds a helper script
bin/cleanup_cloud_artifacts.py
to clean up stale connector and connection definitions left behind by cloud integration tests. The script:--dry-run
mode for safety, requires--no-dry-run
for actual deletionspoe cloud-cleanup
task for easy executionReview & Testing Checklist for Human (4 items)
--no-dry-run
works as expectedTest Plan
poe cloud-cleanup
(dry-run mode) with valid cloud credentials to see what would be deletedpoe cloud-cleanup --no-dry-run
on the test resources to verify actual deletion worksNotes
--help
,--dry-run
, and--no-dry-run
flagsSession: https://app.devin.ai/sessions/b580c93f6f144ca8b141dce686201892
Requested by: @aaronsteers