refactor: split up local cmd.go file #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colesnodgrass
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this isn't annoying, but I get fairly confused about
local/cmd.goandlocal.Commandversuslocal/local_install.goandlocal.InstallCmd. I know the difference (although the line is blurry) but I often get turned around in the code.So, I've split up
local/local/cmd.gointo multiple files (install, uninstall, status). I also split out the mocks intomock_test.goand renamedcmd_test.gotoinstall_test.gosince it only contains install tests.I didn't change any implementation details, this is just moving code around. I would like to make some more changes in a future PR, but I didn't want those to get lost in the big blocks of code moving around here.