Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions internal/cmd/local/helm/airbyte_values.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ func BuildAirbyteValues(ctx context.Context, opts ValuesOpts) (string, error) {
"global.jobs.resources.requests.cpu=0",
"global.jobs.resources.requests.memory=0",

"connector-builder-server.enabled=false",

"workload-launcher.env_vars.CHECK_JOB_MAIN_CONTAINER_CPU_REQUEST=0",
"workload-launcher.env_vars.CHECK_JOB_MAIN_CONTAINER_MEMORY_REQUEST=0",
"workload-launcher.env_vars.DISCOVER_JOB_MAIN_CONTAINER_CPU_REQUEST=0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ airbyte-bootloader:
PLATFORM_LOG_FORMAT: json
global:
auth:
enabled: "true"
enabled: true
env_vars:
AIRBYTE_INSTALLATION_ID: test-user
jobs:
Expand Down
12 changes: 12 additions & 0 deletions internal/maps/maps.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package maps
import (
"fmt"
"os"
"strconv"
"strings"

"gopkg.in/yaml.v3"
Expand Down Expand Up @@ -31,6 +32,17 @@ func FromSlice(slice []string) map[string]any {
for i, k := range keys {
// last key, put the value into the map
if i == len(keys)-1 {
// handle boolean values (convert "true"/"false" strings to Go bool types)
// this is necessary for Helm chart dependency conditions
// which require actual boolean values
if value == "true" || value == "false" {
boolValue, err := strconv.ParseBool(value)
if err == nil {
p[k] = boolValue
continue
}
}

p[k] = value
continue
}
Expand Down
8 changes: 8 additions & 0 deletions internal/maps/maps_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,14 @@ func TestFromSlice(t *testing.T) {
},
},
},
{
name: "boolean values",
input: []string{"a=true", "b=false"},
want: map[string]any{
"a": true,
"b": false,
},
},
}

for _, tt := range tests {
Expand Down