Skip to content

feat: default to local storage #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 5, 2025
Merged

feat: default to local storage #161

merged 4 commits into from
Jun 5, 2025

Conversation

bernielomax
Copy link
Contributor

@bernielomax bernielomax commented Jun 4, 2025 •
edited
Loading

An example of performing an install on a previous Minio installation:

❯ go run main.go local install                           
  INFO    Using Kubernetes provider:
            Provider: kind
            Kubeconfig: /Users/justin.pye/.airbyte/abctl/abctl.kubeconfig
            Context: kind-airbyte-abctl
 SUCCESS  Found Docker installation: version 28.2.1                                                                                           
 WARNING  Found MinIO physical volume. Consider migrating it to local storage (see project docs)                                              
 SUCCESS  Existing cluster 'airbyte-abctl' found                                                                                              
 SUCCESS  Cluster 'airbyte-abctl' validation complete                                                                                         
  INFO    Pulling image airbyte/airbyte-base-java-image:3.3.5

@bernielomax
feat: SupportMinio function
3d715bd 
Checks to see if a Minio volume directory exists.
@bernielomax bernielomax changed the title WIP: refactor: Default to local storage WIP: refactor: default to local storage Jun 4, 2025
@bernielomax bernielomax changed the title WIP: refactor: default to local storage refactor: default to local storage Jun 4, 2025
@bernielomax bernielomax force-pushed the bernielomax/refactor/local-storage-default branch from e52c444 to a6340f8 Compare June 4, 2025 23:19
@bernielomax bernielomax changed the title refactor: default to local storage feat: default to local storage Jun 4, 2025
@bernielomax bernielomax force-pushed the bernielomax/refactor/local-storage-default branch from a6340f8 to 28bf892 Compare June 4, 2025 23:30
@bernielomax bernielomax marked this pull request as ready for review June 4, 2025 23:30
@bernielomax bernielomax requested a review from a team as a code owner June 4, 2025 23:30
@bernielomax bernielomax merged commit c942480 into main Jun 5, 2025
2 checks passed
@bernielomax bernielomax deleted the bernielomax/refactor/local-storage-default branch June 5, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesnodgrass colesnodgrass colesnodgrass approved these changes

@bgroff bgroff bgroff approved these changes

@perangel perangel Awaiting requested review from perangel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bernielomax @colesnodgrass @bgroff