feat: support Airbyte DB with Postgres 17 #162
Conversation
So it can be access by other packages.
This will be used to patch the manifest lists.
bernielomax
force-pushed
the
bernielomax/feat/airbyte-db-psql-17
branch
from
e2c4595 to
6e6bd28
Compare
bernielomax
force-pushed
the
bernielomax/feat/airbyte-db-psql-17
branch
from
6e6bd28 to
ff31206
Compare
bernielomax
changed the title
bernielomax
changed the title
| } | ||
|
|
||
| if opts.PatchPsql17 { | ||
| vals = append(vals, "postgresql.image.tag=1.7.0-17") |
There was a problem hiding this comment.
As we reference this specific version of postgres more than once, can we pull it out to a shared location?
There was a problem hiding this comment.
Added a couple of fixup commits for this.
internal/cmd/local/local/cmd.go
Outdated
| // PatchPsql17 checks if PostgreSQL data needs patching by examining the | ||
| // local PostgreSQL data directory. It returns true if the directory doesn't | ||
| // exist or contains PostgreSQL version 17. Otherwise it returns false. | ||
| func PatchPsql17() (bool, error) { |
There was a problem hiding this comment.
Could we rename this to RunningPsql17? Calling it Patch makes me think this method will patch psql to that version.
There was a problem hiding this comment.
What about EnablePostgres17?
| }) | ||
|
|
||
| pgVersion, err := pgData.Version() | ||
| if err != nil && !errors.Is(err, fs.ErrNotExist) { |
There was a problem hiding this comment.
errors.Is will handle the nil case for you, you don't need to check it explicitly
There was a problem hiding this comment.
The reason why I can't do that is because I am using !. It would also return error when err is nil. See - https://go.dev/play/p/CAN89EgXbav
|
@colesnodgrass I've added a couple of fixups. Let me know what you think about my other two comments. |
2 participants
No description provided.