feat: service manager factory #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This func does not need to be exported. The Run func is better placed at the top of the file.
This struct is used by external packages.
Introduce a factory function to initialize the Kubernetes and Helm clients required by service.Manager. This enables dependency injection of client initialization into commands, improving testability and flexibility. With this approach, clients can be created before constructing the service manager and reused for other command-level operations (like checking Helm chart versions for backward compatibility) without redundant initialization.
Introduce a factory function to initialize the Kubernetes and Helm clients required by service.Manager. This enables dependency injection of client initialization into commands, improving testability and flexibility. With this approach, clients can be created before constructing the service manager and reused for other command-level operations (like checking Helm chart versions for backward compatibility) without redundant initialization.
colesnodgrass
approved these changes
Jul 14, 2025
internal/cmd/local/install.go
Outdated
| } | ||
|
|
||
| func (i *InstallCmd) installOpts(ctx context.Context, user string) (*service.InstallOpts, error) { | ||
| ctx, span := trace.NewSpan(ctx, "InstallCmd.InstallOpts") |
There was a problem hiding this comment.
Suggested change
| ctx, span := trace.NewSpan(ctx, "InstallCmd.InstallOpts") | |
| ctx, span := trace.NewSpan(ctx, "InstallCmd.installOpts") |
|
|
||
| // SvcMgrClientFactory creates and returns the Kubernetes and Helm clients | ||
| // needed by the service manager. | ||
| type SvcMgrClientFactory func(kubeConfig, kubeContext string) (k8s.Client, goHelm.Client, error) |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
installcommand to declare the Kubernetes and Helm clients at the command level. This enables dependency injection into lower-level function calls within the command. A necessary step toward supporting version-specific Helm values since it allows us to query Helm charts and related metadata when generating Helm values. This will obviously assist in maintaining backward compatibility, etc.Apologies for a few sneaky tidy-up commits at the start. I had planned to raise a separate "clean-up" PR, but I think combining them all here provides better context.
There are also a number of sneaky lint changes that snuck in.