Skip to content

fix: --insecure-cookies broke for v2 charts #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2025
+3 −2
Merged

fix: --insecure-cookies broke for v2 charts #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/helm/airbyte_values.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ func buildAirbyteValuesV2(ctx context.Context, opts ValuesOpts) (string, error)

if opts.InsecureCookies {
// Boolean is a string value in the v1 Helm chart.
vals = append(vals, `global.auth.cookieSecureSetting="false"`)
vals = append(vals, `global.auth.security.cookieSecureSetting="false"`)
}

fileVals, err := maps.FromYAMLFile(opts.ValuesFile)
Expand Down
3 changes: 2 additions & 1 deletion internal/helm/airbyte_values_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,8 @@ connectorBuilderServer:
enabled: false
global:
auth:
cookieSecureSetting: '"false"'
security:
cookieSecureSetting: '"false"'
enabled: true
env_vars:
AIRBYTE_INSTALLATION_ID: test-user
Expand Down