fix: include Helm hook resources in images manifest #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The images manifest command was missing images from Helm hook resources like the bootloader Pod. Hook resources are returned separately in rel.Hooks rather than rel.Manifest, so we need to combine both to capture all container images. Also added test coverage for hook resources to prevent regression.
colesnodgrass
approved these changes
Sep 25, 2025
bernielomax
deleted the
bernielomax/fix/image-manifest-includes-bootloader-hook
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The images manifest command was missing images from Helm hook resources like the bootloader Pod. Hook resources are returned separately in rel.Hooks rather than rel.Manifest, so we need to combine both to capture all container images.
Also added test coverage for hook resources to prevent regression.