feat: add global.airbyteUrl Helm value for Airbyte 2.0.0+ #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds global.airbyteUrl=http://localhost:8000 to v2 Helm chart values to support Airbyte platform 2.0.0+, which replaced WEBAPP_URL with AIRBYTE_URL environment variable. Both WEBAPP_URL and airbyteUrl are set for backward compatibility. WEBAPP_URL can be removed once minimum supported Airbyte version is >= 2.0.0.
internal/helm/airbyte_values.go
Outdated
| // Both are set here to support all v2 chart versions. WEBAPP_URL can be removed once all | ||
| // supported chart versions are >= 2.0.0. | ||
| "server.env_vars.WEBAPP_URL=http://airbyte-abctl-airbyte-server-svc:80", | ||
| "global.airbyteUrl=http://localhost:8000", |
There was a problem hiding this comment.
Doesn't this need to be set to the port the user provided?
There was a problem hiding this comment.
Good call. I didn't realize the port was set by flag. 👍
There was a problem hiding this comment.
I have added some changes which should make port settings more dynamic.
colesnodgrass
approved these changes
Oct 9, 2025
|
Confirmed both Helm Charts for Airbyte 2.0.0 and 1.8.5 (backwards compatibility) work when using these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
global.airbyteUrl=http://localhost:8000to v2 Helm chart values to support Airbyte platform 2.0.0+, which replacedWEBAPP_URLwithAIRBYTE_URLenvironment variable.Both
WEBAPP_URLandairbyteUrlare set for backward compatibility.WEBAPP_URLcan be removed once minimum supported Airbyte version is>= 2.0.0.