fix: ingress for airbyte 1.8+ must target server instead of webapp #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colesnodgrass
approved these changes
Oct 9, 2025
| } | ||
|
|
||
| func ingressRulesForV2() networkingv1.IngressRuleValue { | ||
| func ingressRulesForV1_8Plus() networkingv1.IngressRuleValue { |
There was a problem hiding this comment.
using _ in golang methods names is discouraged
| } | ||
|
|
||
| // ChartIsV1_8Plus returns true if the chart version is v1.8.0 or higher | ||
| func ChartIsV1_8Plus(v string) bool { |
There was a problem hiding this comment.
using _ in golang methods names is discouraged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix airbytehq/airbyte#65539
As webapp is already merged into server starting from airbyte 1.8 the ingress must be created accordingly