Skip to content

fix: use correct v2 Helm chart paths for workload resource defaults (AI-Triage PR) #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
devin-ai-integration wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: use correct v2 Helm chart paths for workload resource defaults (AI-Triage PR) #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions internal/helm/airbyte_values.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,8 @@ func buildAirbyteValuesV2(ctx context.Context, opts ValuesOpts) (string, error)
"server.env_vars.WEBAPP_URL=http://airbyte-abctl-airbyte-server-svc",
"global.airbyteUrl=" + airbyteURL,
"global.env_vars.AIRBYTE_INSTALLATION_ID=" + opts.TelemetryUser,
"global.jobs.resources.limits.cpu=3",
"global.jobs.resources.limits.memory=4Gi",
"global.workloads.resources.mainContainer.cpu.limit=3",
"global.workloads.resources.mainContainer.memory.limit=4Gi",
"airbyte-bootloader.env_vars.PLATFORM_LOG_FORMAT=json",
}

Expand All @@ -160,8 +160,8 @@ func buildAirbyteValuesV2(ctx context.Context, opts ValuesOpts) (string, error)
if opts.LowResourceMode {
vals = append(vals,
"server.env_vars.JOB_RESOURCE_VARIANT_OVERRIDE=lowresource",
"global.jobs.resources.requests.cpu=0",
"global.jobs.resources.requests.memory=0",
"global.workloads.resources.mainContainer.cpu.request=0",
"global.workloads.resources.mainContainer.memory.request=0",

"connectorBuilderServer.enabled=false",

Expand Down
27 changes: 15 additions & 12 deletions internal/helm/airbyte_values_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,11 +224,13 @@ global:
enabled: true
env_vars:
AIRBYTE_INSTALLATION_ID: test-user
jobs:
workloads:
resources:
limits:
cpu: "3"
memory: 4Gi
mainContainer:
cpu:
limit: "3"
memory:
limit: 4Gi
server:
env_vars:
WEBAPP_URL: http://airbyte-abctl-airbyte-server-svc
Expand All @@ -253,16 +255,17 @@ global:
AIRBYTE_INSTALLATION_ID: test-user
imagePullSecrets[0]:
name: mysecret
jobs:
resources:
limits:
cpu: "3"
memory: 4Gi
requests:
cpu: "0"
memory: "0"
storage:
type: local
workloads:
resources:
mainContainer:
cpu:
limit: "3"
request: "0"
memory:
limit: 4Gi
request: "0"
postgresql:
image:
tag: 1.7.0-17
Expand Down