Skip to content

Conversation

teallarson
Copy link
Collaborator

@teallarson teallarson commented Apr 29, 2025

Adds a NextJS dev app to ease local development:

  • developing the widget
  • developing the Airbyte webapp within the widget

@teallarson teallarson changed the title wip feat: add demo app, add embedded branding, add mount function Apr 29, 2025
@teallarson teallarson changed the title feat: add demo app, add embedded branding, add mount function feat: add dev app, add embedded branding, add mount function Apr 29, 2025
@teallarson teallarson changed the title feat: add dev app, add embedded branding, add mount function feat: add dev app Apr 29, 2025
@teallarson teallarson marked this pull request as ready for review April 29, 2025 20:11
@teallarson teallarson requested review from girarda and joeykmh April 29, 2025 20:11
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teallarson what's the benefit of a separate app instead of adding an env var to the existing one controlling whether we pull the embedded library from the cdn or locally?

@teallarson
Copy link
Collaborator Author

teallarson commented Apr 29, 2025

  • dev app also adds being able to modify the webapp url (not relevant for an external demo)
  • if/when we split out the demo into a separate repo, we don't have to worry about checking out two separate repos to run this locally
  • the demo app does not support hot module reloading unless we add a web server, which was something we removed from the demo app last week. it's a truly annoying dev experience.

Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🎸

dev/README.md Outdated
NEXT_PUBLIC_CLIENT_ID=
NEXT_PUBLIC_CLIENT_SECRET=
NEXT_PUBLIC_WORKSPACE_ID=
NEXT_PUBLIC_BASE_URL=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add an example or write down that when running locally, this needs to include the /api/public? It might be implied from the variable name, but I suspect I know because I got burnt before and it's not that obvious

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe name it NEXT_PUBLIC_AIRBYTE_PUBLIC_API_BASE_URL? Verbose, but that would have saved me a couple times 😄

Comment on lines +74 to +76
} catch (widgetError) {
throw widgetError;
}
Copy link
Contributor

@joeykmh joeykmh Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary try/catch here?

Copy link
Contributor

@joeykmh joeykmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@teallarson teallarson merged commit dd8964a into main Apr 30, 2025
2 checks passed
@teallarson teallarson deleted the teal/dev-app branch April 30, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants