feat: support for multiple module formats, remove default button #18
Conversation
teallarson
changed the title
There was a problem hiding this comment.
removes as much of the mocking as possible
There was a problem hiding this comment.
multiple export formats. pairs with the rollup and package.json changes.
There was a problem hiding this comment.
removes default button so folks will trigger it using widget.open() now.
There was a problem hiding this comment.
tell rollup how to bundle and export things
There was a problem hiding this comment.
again, to support multiple export formats
There was a problem hiding this comment.
change to support no default button
There was a problem hiding this comment.
changes to support new endpoint
There was a problem hiding this comment.
rearranged a bit to make it clearer what is for a user VS what is for dev. also updated to give multiple usage examples.
There was a problem hiding this comment.
main change here is defining how the exports work, how unpkg/jsdelivr should find the file, etc.
README.md
Outdated
|
|
||
| ## Usage | ||
| ```html | ||
| <script src="https://unpkg.com/@airbyte-embedded/airbyte-embedded-widget"></script> |
There was a problem hiding this comment.
@teallarson do you have a recommendation between unpkg and jsdelivr?
There was a problem hiding this comment.
random google result says uage is a mix: https://w3techs.com/technologies/comparison/cd-cdnjs,cd-jsdelivr,cd-unpkg
a few results mention unpkg being slow so... perhaps jsdelivr is the right one to recommend here
cdnjs you have to manually submit your project to and may require some different configuration (i haven't looked too closely), but unpkg and jsdelivr serve from the npm registry.
There was a problem hiding this comment.
updated to recommend jsdelivr!
|
|
||
| const BASE_URL = process.env.NEXT_PUBLIC_AIRBYTE_PUBLIC_API_URL || "https://local.airbyte.dev/api/public"; | ||
| const AIRBYTE_WIDGET_URL = `${BASE_URL}/v1/embedded/widget`; | ||
| const AIRBYTE_WIDGET_URL = `${BASE_URL}/v1/embedded/widget_token`; |
There was a problem hiding this comment.
womp I forgot to update the dev. thank you!
3 participants
What
closes https://github.com/airbytehq/airbyte-internal-issues/issues/12691