chore: update demo to use iife and update class export name #20
Conversation
| import { EmbeddedWidget } from "https://cdn.jsdelivr.net/npm/@airbyte-embedded/[email protected]/+esm"; | ||
|
|
||
| window.addEventListener("load", async () => { | ||
| <script src="https://cdn.jsdelivr.net/npm/@airbyte-embedded/airbyte-embedded-widget"></script> |
There was a problem hiding this comment.
nice. this will always use the latest version, right?
There was a problem hiding this comment.
it will. It's honestly much better for an Operator to pin a specific version (since version changes could break their implementation). This is low maintenance for us, but not an example of a best practice... I actually had a commit locally to pin the version 😅. Lmk what you think.
There was a problem hiding this comment.
And FWIW our release cadence is pretty likely to slow down here I would imagine. Most of the changes are in the webapp and server, not in the widget itself.
There was a problem hiding this comment.
I agree it's not best practice, but I think the demo should use the latest just to keep the maintenance low. We can tell them to pin in it in the setup instructions
There was a problem hiding this comment.
We can revisit when there’s fewer releases
2 participants
No description provided.