feat: export types and fix styling for projects with global css resets #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teallarson
changed the title
teallarson
commented
Jun 16, 2025
teallarson
commented
Jun 16, 2025
teallarson
commented
Jun 16, 2025
| max-height: 100vh; | ||
| max-width: 100vw; | ||
| overflow: hidden; | ||
| margin: auto; |
There was a problem hiding this comment.
The Big Important Line in this PR.
I was depending upon the native browser styling for dialogs, which centers them on the screen. Anybody who resets browser defaults or uses a framework that resets browser defaults would see the dialog in the top left corner as a result.
teallarson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
margin: autoinstead of depending on native browser styling. This fixes not only Tailwind-based projects, but any project that resets global browser defaults.BEFORE:
AFTER:
