-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix ENV VAR kv parsing to handle JSON values #370
base: main
Are you sure you want to change the base?
Conversation
eab0669
to
aeb73b4
Compare
d1cedc8
to
815223f
Compare
9a8f874
to
8decfab
Compare
8decfab
to
8931902
Compare
8931902
to
aea7b63
Compare
aea7b63
to
8510a86
Compare
This PR will need to be updated against the |
8510a86
to
8d257be
Compare
Sure, I will do it on Monday, thanks! |
e97ab03
to
6fcd3c3
Compare
Hi @colesnodgrass, I've finally got time to remove the usage of lombok. |
6fcd3c3
to
a989fa1
Compare
## What <!-- * Describe what the change is solving. * It helps to add screenshots if it affects the frontend. --> Issue: airbytehq/airbyte#54176 Current Helm `values.yml` documentation and defaults have old unused values for `externalDatabase`, potentially leading to confusion when setting up or upgrading Helm chart versions. ## How <!-- * Describe how code changes achieve the solution. --> This removes `externalDatabase` from all defaults and documentation. These values are not used anywhere in the project outside of the changes files in this PR. Instead `global.database` should be used instead to configure external PostgreSQL connections. ## Can this PR be safely reverted and rolled back? <!-- * If you know that your be safely rolled back, check YES.* * If that is not the case (e.g. a database migration), check NO. * If unsure, leave it blank.* --> - [x] YES 💚 - [ ] NO ❌ Co-authored-by: perangel <[email protected]>
- JOB_KUBE_ANNOTATIONS can have JSON as value - This fixes the parsin of such values
a989fa1
to
6f0bb53
Compare
/create-oss-pr |
What
JOB_KUBE_ANNOTATIONS environment variable can be used to define one or more Job pod annotations. The valid value can be a JSON value (see example below). Current logic to process the
key:value
pairs is not allowing to pass the JSON value.Before fix:
Example of a valid istio k8s annotation that is incorrectly parsed without a fix:
How
Splitter
stream.Recommended reading order
airbyte-commons-with-dependencies/src/main/java/io/airbyte/commons/workers/config/EnvUtils.java
airbyte-commons-with-dependencies/src/main/java/io/airbyte/commons/workers/config/WorkerConfigsProvider.java
airbyte-commons-with-dependencies/src/test/java/io/airbyte/commons/workers/config/EnvUtilsTest.java
Can this PR be safely reverted and rolled back?