Skip to content

ASRE-931: Add new variable shareProcessNamespace #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

ASRE-931: Add new variable shareProcessNamespace #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a10cf6d
ASRE-550: Fix WORKLOAD_API_BEARER_TOKEN issue
sho34215 Dec 6, 2024
6c98516
Merge pull request #1 from equativ/ASRE-550
sho-equativ Dec 6, 2024
1e433fb
ASRE-550: Fix _database/tpl with password and user
sho-equativ Dec 6, 2024
80de2c2
Merge pull request #2 from equativ/ASRE-550
sho-equativ Dec 6, 2024
c3a763d
Add new shareProcessNamespace
sho34215 Dec 17, 2024
115d7bf
Merge pull request #3 from equativ/feature
sho-equativ Dec 17, 2024
cf87933
ASRE-931: Update code to add shareProcessNamespace
sho34215 Jan 6, 2025
12bdd54
Merge pull request #4 from equativ/ASRE-931
sho-equativ Jan 6, 2025
ff8b012
ASRE-931: Fix shareProcessNamespace issue
sho34215 Jan 7, 2025
e05b8c2
Merge pull request #5 from equativ/ASRE-931
sho-equativ Jan 7, 2025
b32e25a
ASRE-931: Fix shareProcessNamespace issue
sho34215 Jan 7, 2025
5c9ff98
ASRE-931: Fix temporal ui
sho34215 Jan 9, 2025
eeb6ce8
ASRE-932: Fix main_container_image_pull_secret nil
sho34215 Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/airbyte-bootloader/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,6 @@ Helm chart to deploy airbyte-bootloader
| resources.limits | object | `{}` | |
| resources.requests | object | `{}` | |
| secrets | object | `{}` | |
| shareProcessNamespace | string | `"false"` | the shareProcessNamespace field is used in a PodSpec to enable all containers within a pod to share the same process namespace. This allows containers to view and interact with each other's processes. |
| tolerations | list | `[]` | |

3 changes: 3 additions & 0 deletions charts/airbyte-bootloader/templates/pod.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ metadata:
{{- include "common.tplvalues.render" (dict "value" .Values.podAnnotations "context" $) | nindent 4 }}
{{- end }}
spec:
{{- if .Values.shareProcessNamespace }}
shareProcessNamespace: true
{{- end }}
serviceAccountName: {{ .Values.global.serviceAccountName }}
{{- if .Values.global.imagePullSecrets }}
imagePullSecrets:
Expand Down
2 changes: 2 additions & 0 deletions charts/airbyte-bootloader/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ image:
repository: airbyte/bootloader
pullPolicy: IfNotPresent

shareProcessNamespace: false

## podAnnotations [object] Add extra annotations to the bootloader pod
##
podAnnotations: {}
Expand Down
10 changes: 5 additions & 5 deletions charts/airbyte-temporal-ui/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@ spec:
{{- if .Values.global.extraContainers }}
{{ toYaml .Values.global.extraContainers | nindent 6 }}
{{- end }}
securityContext: {{- toYaml .Values.podSecurityContext | nindent 8 }}
volumes:
{{- if .Values.extraVolumes }}
{{ toYaml .Values.extraVolumes | nindent 6 }}
{{- end }}
securityContext: {{- toYaml .Values.podSecurityContext | nindent 8 }}
volumes:
{{- if .Values.extraVolumes }}
{{ toYaml .Values.extraVolumes | nindent 6 }}
{{- end }}
4 changes: 2 additions & 2 deletions charts/airbyte/templates/_database.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,11 +207,11 @@ Renders all of the common environment variables which provide database credentia
Renders a set of database secrets to be included in the shared Airbyte secret
*/}}
{{- define "airbyte.database.secrets" }}
{{ $user := (include "airbyte.database.user" .)}}
{{ $user := (include "airbyte.database.user" .) | trim }}
{{- if not (empty $user) }}
DATABASE_USER: {{ $user }}
{{- end }}
{{ $password := (include "airbyte.database.password" .)}}
{{ $password := (include "airbyte.database.password" .) | trim }}
{{- if not (empty $password) }}
DATABASE_PASSWORD: {{ $password }}
{{- end}}
Expand Down
4 changes: 2 additions & 2 deletions charts/airbyte/templates/env-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,9 @@ data:
JOB_MAIN_CONTAINER_MEMORY_LIMIT: {{ ((.Values.global.jobs.resources | default dict).limits | default dict).memory | default "" | quote }}
JOB_MAIN_CONTAINER_MEMORY_REQUEST: {{ ((.Values.global.jobs.resources | default dict).requests | default dict).memory | default "" | quote }}

{{- if $.Values.global.jobs.kube.main_container_image_pull_secret }}
{{- if and $.Values.global.jobs.kube.main_container_image_pull_secret (ne $.Values.global.jobs.kube.main_container_image_pull_secret "") }}
JOB_KUBE_MAIN_CONTAINER_IMAGE_PULL_SECRET: {{ $.Values.global.jobs.kube.main_container_image_pull_secret }}
{{- end }}
{{- end }}
JOBS_DATABASE_MINIMUM_FLYWAY_MIGRATION_VERSION: "0.29.15.001"

JOB_KUBE_LOCAL_VOLUME_ENABLED: {{ .Values.global.jobs.local.volume.enabled | quote }}
Expand Down
2 changes: 1 addition & 1 deletion charts/airbyte/templates/secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ stringData:
KEYCLOAK_ADMIN_USER: {{ .Values.keycloak.auth.adminUsername | quote }}
KEYCLOAK_ADMIN_PASSWORD: {{ .Values.keycloak.auth.adminPassword | quote }}
{{- end }}
WORKLOAD_API_BEARER_TOKEN: {{ index ".Values.workload-api.bearerToken" | quote }}
WORKLOAD_API_BEARER_TOKEN: {{ index .Values "workload-api-server" "bearerToken" | quote }}
Loading