Skip to content

Local monitoring #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
192 changes: 156 additions & 36 deletions charts/airbyte/values.yaml

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ spec:
{{- include "airbyte.connectorBuilder.envs" . | nindent 8 }}
{{- include "airbyte.metrics.envs" . | nindent 8 }}
{{- include "airbyte.tracking.envs" . | nindent 8 }}
{{- include "airbyte.datadog.envs" . | nindent 8 }} # Add this line

{{- if (eq .Values.global.edition "enterprise") }}
{{- include "airbyte.enterprise.envs" . | nindent 8 }}
Expand Down Expand Up @@ -123,7 +124,7 @@ spec:
containerPort: 8080
protocol: TCP
{{- if .Values.connectorBuilderServer.debug.enabled }}
- name: debug
- name: debug
containerPort: {{ .Values.connectorBuilderServer.debug.remoteDebugPort }}
protocol: TCP
{{- end}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ spec:

{{- include "airbyte.common.envs" . | nindent 8 }}
{{- include "airbyte.logging.envs" . | nindent 8 }}
{{- include "airbyte.datadog.envs" . | nindent 8 }}
{{- include "airbyte.metrics.envs" . | nindent 8 }}
{{- include "airbyte.tracking.envs" . | nindent 8 }}
{{- include "airbyte.temporal.envs" . | nindent 8 }}
Expand Down
4 changes: 3 additions & 1 deletion charts/v2/airbyte/templates/airbyte-cron/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,15 @@ spec:
image: {{ include "imageUrl" (list .Values.cron.image $) }}
imagePullPolicy: "{{ .Values.cron.image.pullPolicy }}"
env:
# Add Datadog envs before other environment variables
{{- include "airbyte.datadog.envs" . | nindent 10 }}
{{- include "airbyte.metrics.envs" . | nindent 10 }}

{{- include "airbyte.common.envs" . | nindent 10 }}
{{- include "airbyte.cron.envs" . | nindent 10 }}
{{- include "airbyte.database.envs" . | nindent 10 }}
{{- include "airbyte.database.migrations.envs" . | nindent 10 }}
{{- include "airbyte.featureFlags.envs" . | nindent 10 }}
{{- include "airbyte.metrics.envs" . | nindent 10 }}
{{- include "airbyte.micronaut.envs" . | nindent 10 }}
{{- include "airbyte.temporal.envs" . | nindent 10 }}
{{- include "airbyte.tracking.envs" . | nindent 10 }}
Expand Down
3 changes: 2 additions & 1 deletion charts/v2/airbyte/templates/airbyte-metrics/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ spec:
{{- end }}
spec:
serviceAccountName: {{ .Values.global.serviceAccountName }}
{{- if .Values.global.imagePullSecrets }}
{{- if .Values.global.imagePullSecrets }}
imagePullSecrets:
{{- range .Values.global.imagePullSecrets }}
{{- printf "- name: %s" .name | nindent 8 }}
Expand All @@ -57,6 +57,7 @@ spec:
{{- include "airbyte.database.envs" . | nindent 8 }}
{{- include "airbyte.database.migrations.envs" . | nindent 8 }}
{{- include "airbyte.metrics.envs" . | nindent 8 }}
{{- include "airbyte.datadog.envs" . | nindent 8 }} # Add this line

# Values from secret
{{- if .Values.metrics.secrets }}
Expand Down
17 changes: 9 additions & 8 deletions charts/v2/airbyte/templates/airbyte-server/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,15 @@ spec:
value: "Internal server"
{{- end}}

{{- include "airbyte.auth.security.envs" . | nindent 8 }}
{{- include "airbyte.common.envs" . | nindent 8 }}
{{- include "airbyte.auth.security.envs" . | nindent 8 }}
{{- include "airbyte.common.envs" . | nindent 8 }}
{{- include "airbyte.metrics.envs" . | nindent 8 }} # Add this line
{{- include "airbyte.datadog.envs" . | nindent 8 }} # Add this line
{{- include "airbyte.cluster.envs" . | nindent 8 }}
{{- include "airbyte.connector.envs" . | nindent 8 }}
{{- include "airbyte.database.envs" . | nindent 8 }}
{{- include "airbyte.database.migrations.envs" . | nindent 8 }}
{{- include "airbyte.logging.envs" . | nindent 8 }}
{{- include "airbyte.metrics.envs" . | nindent 8 }}
{{- include "airbyte.logging.envs" . | nindent 8 }}
{{- include "airbyte.micronaut.envs" . | nindent 8 }}
{{- include "airbyte.storage.envs" . | nindent 8 }}
{{- include "airbyte.secretsManager.envs" . | nindent 8 }}
Expand All @@ -88,15 +89,15 @@ spec:
{{- include "airbyte.workloads.resources.envs" . | nindent 8 }}

{{- if or (eq .Values.global.edition "enterprise") (eq .Values.global.edition "pro") }}
{{- include "airbyte.auth.instanceAdmin.enterprise.envs" . | nindent 8 }}
{{- include "airbyte.auth.identityProvider.envs" . | nindent 8 }}
{{- include "airbyte.auth.instanceAdmin.enterprise.envs" . | nindent 8 }}
{{- include "airbyte.auth.identityProvider.envs" . | nindent 8 }}
{{- include "airbyte.enterprise.envs" . | nindent 8 }}
{{- include "airbyte.keycloak.envs" . | nindent 8 }}
{{- include "airbyte.keycloak.admin.client.envs" . | nindent 8 }}
{{- include "airbyte.keycloak.admin.user.envs" . | nindent 8 }}
{{- else if (eq .Values.global.deploymentMode "oss") }}
{{- include "airbyte.auth.envs" . | nindent 8 }}
{{- include "airbyte.auth.jwt.envs" . | nindent 8 }}
{{- include "airbyte.auth.envs" . | nindent 8 }}
{{- include "airbyte.auth.jwt.envs" . | nindent 8 }}
{{- else }}
{{- include "airbyte.cloudApi.envs" . | nindent 8 }}
{{- include "airbyte.keycloak.admin.client.envs" . | nindent 8 }}
Expand Down
6 changes: 5 additions & 1 deletion charts/v2/airbyte/templates/airbyte-temporal/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,11 @@ spec:
{{- end }}
{{- end }}
ports:
- containerPort: 7233
- name: temporal # Added name for the main temporal port
containerPort: 7233
# Add metrics port
- name: metrics
containerPort: 9090
{{- if .Values.temporal.containerSecurityContext }}
securityContext: {{- toYaml .Values.temporal.containerSecurityContext | nindent 10 }}
{{- end }}
Expand Down
5 changes: 5 additions & 0 deletions charts/v2/airbyte/templates/airbyte-temporal/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ spec:
- port: {{ .Values.temporal.service.port }}
protocol: TCP
targetPort: 7233
name: temporal
- port: {{ .Values.temporal.service.metricsPort }}
name: metrics
targetPort: 9090
protocol: TCP
selector:
{{- include "airbyte.selectorLabels" . | nindent 4 }}
{{- if .Values.temporal.extraSelectorLabels }}
Expand Down
3 changes: 3 additions & 0 deletions charts/v2/airbyte/templates/airbyte-webapp/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ spec:
{{ include "airbyte.keycloak.admin.client.internalHost.env" . | nindent 8 }}
{{ include "airbyte.tracking.envs" . | nindent 8 }}
{{ include "airbyte.webapp.envs" . | nindent 8 }}
{{- include "airbyte.datadog.envs" . | nindent 8 }}
{{- include "airbyte.metrics.envs" . | nindent 8 }}


# Values from secret
{{- if .Values.webapp.secrets }}
Expand Down
1 change: 1 addition & 0 deletions charts/v2/airbyte/templates/airbyte-worker/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ spec:

{{- include "airbyte.common.envs" . | nindent 8 }}
{{- include "airbyte.database.envs" . | nindent 8 }}
{{- include "airbyte.datadog.envs" . | nindent 8 }} # Add this line
{{- include "airbyte.database.migrations.envs" . | nindent 8 }}
{{- include "airbyte.jobs.envs" . | nindent 8 }}
{{- include "airbyte.jobs.errors.envs" . | nindent 8 }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ spec:
{{- include "airbyte.database.envs" . | nindent 8 }}
{{- include "airbyte.keycloak.admin.client.realmIssuer.env" . | nindent 8 }}
{{- include "airbyte.metrics.envs" . | nindent 8 }}
{{- include "airbyte.datadog.envs" . | nindent 8 }}
{{- include "airbyte.micronaut.envs" . | nindent 8 }}
{{- include "airbyte.temporal.envs" . | nindent 8 }}
{{- include "airbyte.workloadApiServer.envs" . | nindent 8 }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,14 @@ spec:

{{- include "airbyte.cluster.envs" . | nindent 8 }}
{{- include "airbyte.common.envs" . | nindent 8 }}
{{- include "airbyte.metrics.envs" . | nindent 8 }} # Add this line
{{- include "airbyte.datadog.envs" . | nindent 8 }} # Add this line
{{- include "airbyte.database.envs" . | nindent 8 }}
{{- include "airbyte.database.migrations.envs" . | nindent 8 }}
{{- include "airbyte.jobs.envs" . | nindent 8 }}
{{- include "airbyte.jobs.errors.envs" . | nindent 8 }}
{{- include "airbyte.keycloak.admin.client.realmIssuer.env" . | nindent 8 }}
{{- include "airbyte.logging.envs" . | nindent 8 }}
{{- include "airbyte.metrics.envs" . | nindent 8 }}
{{- include "airbyte.micronaut.envs" . | nindent 8 }}
{{- include "airbyte.storage.envs" . | nindent 8 }}
{{- include "airbyte.secretsManager.envs" . | nindent 8 }}
Expand Down
19 changes: 8 additions & 11 deletions charts/v2/airbyte/templates/config/_datadog.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,6 @@ Renders the global.datadog.agentHost value
{{- .Values.global.datadog.agentHost }}
{{- end }}

{{/*
Renders the datadog.agentHost environment variable
*/}}
{{- define "airbyte.datadog.agentHost.env" }}
- name: DD_AGENT_HOST
valueFrom:
fieldRef:
fieldPath: status.hostIP

{{- end }}

{{/*
Renders the global.datadog.enabled value
*/}}
Expand Down Expand Up @@ -311,6 +300,14 @@ Renders the global.datadog.integrations.urlConnection.enabled value
{{- .Values.global.datadog.integrations.urlConnection.enabled | default false }}
{{- end }}

{{- define "airbyte.datadog.agentHost.env" }}
- name: DD_AGENT_HOST
valueFrom:
configMapKeyRef:
name: {{ .Release.Name }}-airbyte-env
key: DD_AGENT_HOST
{{- end }}

{{/*
Renders the datadog.integrations.urlConnection.enabled environment variable
*/}}
Expand Down
19 changes: 8 additions & 11 deletions charts/v2/airbyte/templates/config/_metrics.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -95,17 +95,6 @@ Renders the global.metrics.statsd.host value
{{- .Values.global.metrics.statsd.host }}
{{- end }}

{{/*
Renders the metrics.statsd.host environment variable
*/}}
{{- define "airbyte.metrics.statsd.host.env" }}
- name: STATSD_HOST
valueFrom:
fieldRef:
fieldPath: status.hostIP

{{- end }}

{{/*
Renders the global.metrics.statsd.port value
*/}}
Expand All @@ -124,6 +113,14 @@ Renders the metrics.statsd.port environment variable
key: STATSD_PORT
{{- end }}

{{- define "airbyte.metrics.statsd.host.env" }}
- name: STATSD_HOST
valueFrom:
configMapKeyRef:
name: {{ .Release.Name }}-airbyte-env
key: STATSD_HOST
{{- end }}

{{/*
Renders the set of all metrics environment variables
*/}}
Expand Down
Loading
Loading