Add webapp.url back into values.yaml #393
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## What <!-- * Describe what the change is solving. * It helps to add screenshots if it affects the frontend. --> Issue: airbytehq/airbyte#54176 Current Helm `values.yml` documentation and defaults have old unused values for `externalDatabase`, potentially leading to confusion when setting up or upgrading Helm chart versions. ## How <!-- * Describe how code changes achieve the solution. --> This removes `externalDatabase` from all defaults and documentation. These values are not used anywhere in the project outside of the changes files in this PR. Instead `global.database` should be used instead to configure external PostgreSQL connections. ## Can this PR be safely reverted and rolled back? <!-- * If you know that your be safely rolled back, check YES.* * If that is not the case (e.g. a database migration), check NO. * If unsure, leave it blank.* --> - [x] YES 💚 - [ ] NO ❌ Co-authored-by: perangel <[email protected]>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Somehow
webapp.urlwas removed from the examplevalues.yamlfile. This was introduced initially as part of this pull request:#260
But has since been removed. This value is required to change the links in the notifications, and likely other things.
How
Reverted the line back into existence.
Can this PR be safely reverted and rolled back?