Skip to content

Conversation

dmeneguin
Copy link

@dmeneguin dmeneguin commented May 22, 2025

What

airbyte-connector-rollout-client: the temporal parameters in application yaml are in a different structure than the expected in code:

@Value("\${temporal.cloud.connector-rollout.host}") temporalCloudHost: String?,
@Value("\${temporal.cloud.connector-rollout.namespace}") temporalCloudNamespace: String?,

How

this PR adjusts the application.yaml to be equal as the expected in the ConnectorRolloutTemporalWorkflowServiceFactory.kt file

Recommended reading order

  1. airbyte-connector-rollout-client/src/main/kotlin/io/airbyte/connector/rollout/client/ConnectorRolloutTemporalWorkflowServiceFactory.kt
  2. airbyte-connector-rollout-client/src/main/resources/application.yml

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dmeneguin dmeneguin closed this May 23, 2025
@dmeneguin dmeneguin reopened this May 23, 2025
@dmeneguin dmeneguin closed this May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants