chore: Remove errant Workspace#list entity operation #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expected entity operations for downstream tooling are one of `create`, `read`, `update`, and `delete`: ``` Error: Unexpected op annotation list applied as Workspace#list: expected it to be one of ["create","read","update","delete"] ``` Since the `listWorkspaces` API operation appears to be intended as its own Terraform data resource and its usage would be separate from the workspace managed resource, the entity operation could be updated to create a workspaces data resource via `Workspaces#read`. However, it is removed for now to match the current behavior of not doing anything in the Terraform code generation while also preventing the error.
|
|
|
Hi, we've decided to stop accepting PRs in this repo, so we can focus on supporting our connector contributors. I'm going to close this issue. We appreciate your work here. Please feel free to post an issue in https://github.com/airbytehq/airbyte. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The expected entity operations for downstream tooling are one of
create,read,update, anddelete:Since the
listWorkspacesAPI operation appears to be intended as its own Terraform data resource and its usage would be separate from the workspace managed resource, the entity operation could be updated to create a workspaces data resource viaWorkspaces#read. However, it is removed for now to match the current behavior of not doing anything in the Terraform code generation while also preventing the error.How
Removed various
x-sdk-entity-operation: Workspace#listandx-speakeasy-entity-operation: Workspace#listusage in OpenAPI Specification documents.Recommended reading order
x.kty.ktCan this PR be safely reverted and rolled back?