Skip to content

fix(helm-charts): test-webapp allow the use of redirect in args #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(helm-charts): test-webapp allow the use of redirect in args #419

wants to merge 1 commit into from

Conversation

florentortiz
Copy link

What

The test-webapp.yaml pod always exit in an error code 3 due to curl.

It seems that the redirect > in the args parameter is not well handle, as the pod show curl logs:

$ kubectl logs -f airbyte-test-connection
<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="utf-8">
    <link rel="icon" href="/favicon.ico">
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <meta name="theme-color" content="#000000">
    <meta
      name="description"
      content="Airbyte is the turnkey open-source data integration platform that syncs data from applications, APIs and databases to warehouses."
    >

The proper formatted command executed inside the pod show nothing as it should be:

$ k exec -it airbyte-test-connection -- sh
sh-4.2$ 
sh-4.2$ curl -s airbyte-airbyte-webapp-svc:80 > /dev/null
sh-4.2$ exit

How

By using the Kubernetes way to run a command in a shell:
https://kubernetes.io/docs/tasks/inject-data-application/define-command-argument-container/#run-a-command-in-a-shell

We allow the use of the redirect > /dev/null

Recommended reading order

N/A

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@florentortiz florentortiz changed the title fix(helm-cahrts): test-webapp allow the use of redirect in args fix(helm-charts): test-webapp allow the use of redirect in args Jul 17, 2025
@florentortiz florentortiz force-pushed the ortizflorent/fix-testwebapp-args-redirect branch from 7a52bd1 to cb0cf71 Compare July 17, 2025 14:36
@cgardens
Copy link
Contributor

Hi, we've decided to stop accepting PRs in this repo, so we can focus on supporting our connector contributors. I'm going to close this issue. We appreciate your work here. Please feel free to post an issue in https://github.com/airbytehq/airbyte.

@cgardens cgardens closed this Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/platform kubernetes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@florentortiz @cgardens @octavia-squidington-iii