Skip to content

Conversation

bgrams
Copy link

@bgrams bgrams commented Jul 21, 2025

What

Persist the Enterprise webapp login state within the browser to avoid reauthenticating in new sessions. Links that open a new tab or window will otherwise re-initiate the login flow and redirect to the workspace landing page.

This addresses airbytehq/airbyte#63355, but note that the redirect issue still may arise upon "initial" user login, after which navigation is expected to behave correctly. So there still may be an opportunity to improve redirect behavior within the webapp, but this is outside of my expertise.

How

Add a WebStorageStateStore to the react-oidc-context configuration that uses local browser storage for the ID and access tokens.

Recommended reading order

  1. EnterpriseAuthService.tsx

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@CLAassistant
Copy link

CLAassistant commented Jul 21, 2025

CLA assistant check
All committers have signed the CLA.

@bgrams bgrams force-pushed the webapp-auth-local-storage branch from 2edcb52 to abc2ced Compare July 21, 2025 14:35
@joeykmh
Copy link
Contributor

joeykmh commented Jul 22, 2025

Thanks for this contribution! I merged a similar PR in our upstream repository, of which airbytehq/airbyte-platform is a mirror. So this change will go out in the next release of the Airbyte platform.

@joeykmh joeykmh closed this Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants