fix: use local storage for enterprise auth #420
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Persist the Enterprise webapp login state within the browser to avoid reauthenticating in new sessions. Links that open a new tab or window will otherwise re-initiate the login flow and redirect to the workspace landing page.
This addresses airbytehq/airbyte#63355, but note that the redirect issue still may arise upon "initial" user login, after which navigation is expected to behave correctly. So there still may be an opportunity to improve redirect behavior within the webapp, but this is outside of my expertise.
How
Add a
WebStorageStateStore
to thereact-oidc-context
configuration that uses local browser storage for the ID and access tokens.Recommended reading order
EnterpriseAuthService.tsx
Can this PR be safely reverted and rolled back?