fix: (DeclarativeOAuthFlow) - add access_token_params property to match the actual spec properties
#103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erohmensing
approved these changes
Nov 27, 2024
protocol-models/src/main/resources/airbyte_protocol/airbyte_protocol.yaml
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
While working on the migration for
TikTok MarketingOAuthFlow, there was a need to encode theaccess_token_urlquery parameters tojson stringinstead ofurl_encodedparameters.The
access_token_paramsis there to provide such a functionality, in order to match the actual spec provided with the designedprotocolDeclarativeOAuth spec this property should exist at theprotocollevel.How
access_token_paramsobject property to theOAuthConfigSpecification.oauth_connector_input_specification.propertiesadditionalPropertiesset totrueto allow future lazy spec improvements, even though the protocol could be behind of the actual source / destination spec, allowing us to provide more properties to work with.