fix: python generation scripts #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroslopez
reviewed
Jun 17, 2025
Comment on lines
-31
to
+36
| --input "$ROOT_DIR/$YAML_DIR/$filename_wo_ext.yaml" \ | ||
| --input "$f" \ |
There was a problem hiding this comment.
this would no longer generate the v0 file right? do we need that for anything else? (not sure if there are other consumers of the protocol)
There was a problem hiding this comment.
oh maybe the output is still the same?
There was a problem hiding this comment.
My understanding is that it never generated the V0 files. However when I compared v0 and v2 airbyte_protocol.yaml files, they were the same (except some formatting and comments differing)
pedroslopez
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Following this PR, Python generation scripts do not work ; they don't generate the
protocol-models/python/*/*/models/airbyte_protocol.pyfileHow
Ensuring that the airbyte_protocol.yaml file is not in
$ROOT_DIR/$YAML_DIRand generating theairbyte_protocol.pyfile using the yaml file under thev0folder.In case the yaml file exist in both folders, the script will print
ERROR: File airbyte_protocol.yaml exists in both /airbyte-protocol/protocol-models/src/main/resources/airbyte_protocol and /airbyte-protocol/protocol-models/src/main/resources/airbyte_protocol/v0. Only one is expectedand will exit.