feat(low code cdk): add path to filter interpolation in AddFields condition

[darynaishchenko]

What

Needed for mixpanel dynamic schemas airbytehq/airbyte#55189
When stream has static fields in schema, they should be added only when dynamic schema doesn't have these fields in it.

How

To check if field already exists in schema a condition in AddFields transformation can be used, but now it doesn't have path value in interpolation arguments.
Added path=parsed_field.path to _filter_interpolator.eval.

Summary by CodeRabbit

• Refactor
  • Enhanced field processing by refining the transformation logic to incorporate additional context during condition checks. This update improves how fields are added based on record content, ensuring more consistent and reliable outcomes during data processing. These enhancements contribute to a smoother and more predictable overall experience when working with records.

[darynaishchenko]

/autofix

Auto-Fix Job Info

This job attempts to auto-fix any linting or formating issues. If any fixes are made,
those changes will be automatically committed and pushed back to the PR.

Note: This job can only be run by maintainers. On PRs from forks, this command requires
that the PR author has enabled the Allow edits from maintainers option.

PR auto-fix job started... Check job output.

✅ Changes applied successfully.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request updates the transform method in the AddFields class by adding the argument path=parsed_field.path when calling _filter_interpolator.eval(). This change provides additional context for evaluating filter conditions. Additionally, two new test cases have been added to verify the behavior when a field’s path is either absent or already present in the record. No changes were made to the public API declarations.

Changes

File(s)	Change Summary
airbyte_cdk/.../add_fields.py	Updated the conditional check in the transform method to pass an extra argument: path=parsed_field.path to _filter_interpolator.eval().
unit_tests/.../test_add_fields.py	Added two new parameterized test cases to validate field addition logic based on whether the field's path exists or is absent in the input record.

Sequence Diagram(s)

sequenceDiagram
    participant C as Client
    participant AF as AddFields
    participant FI as FilterInterpolator

    C->>AF: Call transform(record, parsed_field, ...)
    AF->>FI: eval(value, kwargs, path=parsed_field.path)
    FI-->>AF: Return condition result (true/false)
    alt Condition True
        AF->>AF: Add new field to record
    else Condition False
        AF->>AF: Record remains unchanged
    end
    AF-->>C: Return updated record

Loading

Possibly related PRs

• feat(low-code cdk): add condition to add fields #409: This PR also modified the transform method in the AddFields class, introducing context to conditional evaluations.
• feat(low-code): add DpathFlattenFields #227: The changes in this PR enhance record transformation logic based on field paths, similar to the modifications made here.
• fix: (CDK) (DpathExtractor) - fix schema causing the typescript type generation in the FE #406: Adjustments in the definition and usage of the AddFields class in this PR are closely aligned with the changes implemented here.

Suggested reviewers

• maxi297 – Would you be comfortable reviewing these modifications, wdyt?
• lazebnyi – Could you take a look at the conditional logic updates and added tests, wdyt?
• natikgadzhi – Are you available to review the test enhancements and their impact on field handling, wdyt?

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 79cb1c1 and be21e83.

📒 Files selected for processing (1)

• airbyte_cdk/sources/declarative/transformations/add_fields.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• airbyte_cdk/sources/declarative/transformations/add_fields.py

⏰ Context from checks skipped due to timeout of 90000ms (8)

• GitHub Check: Check: 'source-pokeapi' (skip=false)
• GitHub Check: Check: 'source-amplitude' (skip=false)
• GitHub Check: Check: 'source-shopify' (skip=false)
• GitHub Check: Check: 'source-hardcoded-records' (skip=false)
• GitHub Check: Pytest (All, Python 3.11, Ubuntu)
• GitHub Check: Pytest (All, Python 3.10, Ubuntu)
• GitHub Check: SDM Docker Image Build
• GitHub Check: Pytest (Fast)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[maxi297]