Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(low code cdk): add path to filter interpolation in AddFields condition #454

Merged
merged 2 commits into from
Apr 1, 2025
Merged

feat(low code cdk): add path to filter interpolation in AddFields condition #454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79cb1c1
add path to filter interpolation in AddFields condition
darynaishchenko Apr 1, 2025
be21e83
Auto-fix lint and format issues
Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion airbyte_cdk/sources/declarative/transformations/add_fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,9 @@ def transform(
valid_types = (parsed_field.value_type,) if parsed_field.value_type else None
value = parsed_field.value.eval(config, valid_types=valid_types, **kwargs)
is_empty_condition = not self.condition
if is_empty_condition or self._filter_interpolator.eval(config, value=value, **kwargs):
if is_empty_condition or self._filter_interpolator.eval(
config, value=value, path=parsed_field.path, **kwargs
):
dpath.new(record, parsed_field.path, value)

def __eq__(self, other: Any) -> bool:
Expand Down
18 changes: 18 additions & 0 deletions unit_tests/sources/declarative/transformations/test_add_fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,24 @@
{"k": "v", "path": "static_value"},
id="add all fields if condition is boolean True",
),
pytest.param(
{"k": "v"},
[(["path"], "static_value")],
None,
"{{ path[0] not in record.keys() }}",
{},
{"k": "v", "path": "static_value"},
id="add fields when condition uses path value",
),
pytest.param(
{"k": "v", "existing_path": "record_value"},
[(["existing_path"], "static_value")],
None,
"{{ path[0] not in record.keys() }}",
{},
{"k": "v", "existing_path": "record_value"},
id="do not add fields when condition uses path value",
),
],
)
def test_add_fields(
Expand Down
Loading