-
Notifications
You must be signed in to change notification settings - Fork 17
feat(cli): Add image build
command to airbyte-cdk
CLI
#489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devin-ai-integration
wants to merge
51
commits into
aj/feat/add-standard-tests-cli
Choose a base branch
from
devin/1744841809-add-build-command
base: aj/feat/add-standard-tests-cli
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(cli): Add image build
command to airbyte-cdk
CLI
#489
devin-ai-integration
wants to merge
51
commits into
aj/feat/add-standard-tests-cli
from
devin/1744841809-add-build-command
+493
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Original prompt from Aaron:
|
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
aaronsteers
reviewed
Apr 17, 2025
aaronsteers
reviewed
Apr 17, 2025
…/docker for Dockerfile Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
aaronsteers
reviewed
Apr 17, 2025
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
aaronsteers
reviewed
Apr 17, 2025
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
…s to models directory Co-Authored-By: Aaron <AJ> Steers <[email protected]>
…p of temporary files Co-Authored-By: Aaron <AJ> Steers <[email protected]>
…ailable Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
aaronsteers
reviewed
Apr 18, 2025
aaronsteers
reviewed
Apr 18, 2025
aaronsteers
reviewed
Apr 18, 2025
… fix entry point Co-Authored-By: Aaron <AJ> Steers <[email protected]>
aaronsteers
reviewed
Apr 18, 2025
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
aaronsteers
reviewed
Apr 18, 2025
d2c9fc9
to
71652ef
Compare
image build
command to airbyte-cdk
CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes from AJ (@aaronsteers):
This PR allows you to quickly build a docker image for your connector. This is a follow-on to the previous PR that added
connector test
andsecrets fetch
capabilities. It uses most of the same practices as the officialairbyte-ci
pipeline, but it is faster and has some modest improvements.See the base PR for more context on the CLI in general:
airbyte-cdk
CLI with support for:connector test
,secrets fetch
and--version
#493Other notes:
sources-s3
you'll have images:airbyte/source-s3:dev-linux-amd64
airbyte/source-s3:dev-linux-arm64
airbyte/source-s3:dev
(same as the ARM64 one, assuming for now that local dev is happening on an M-series Mac).uv
instead ofpip
to do the install. This speeds up the builds significantly.airbyte-cdk
CLI commands, you can run this statelessly usinguvx airbyce-cdk image build
. This doesn't require pre-installing the CDK, and will use the latest CDK version by default.airbyte-ci
for build+publish. We can discuss this, but currently, this functionality is only for dev/test workflows.https://www.loom.com/share/5ca23374a5e24af1a4163597e3048154?sid=47e4cfa3-3a03-4eea-beb3-9a9dca3cb0ea
Notes From Devin:
Adds a new
airbyte-cdk image build
command to the Python CDK that allows building connector Docker images directly using Docker, without requiring the Dagger pipeline used inairbyte-ci build
.This PR:
airbyte-cdk image build
spec
commandRequested by: Aaron ("AJ") Steers ([email protected])
Link to Devin run: https://app.devin.ai/sessions/6a63c18a1da44463a87b2099bcd1c092