Skip to content

fix: make concurrent declarative source test order-agnostic #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: make concurrent declarative source test order-agnostic #742

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
359b18f
fix: make concurrent declarative source test order-agnostic
devin-ai-integration[bot] Aug 29, 2025
092b4a4
fix: apply ruff formatting to test assertion
devin-ai-integration[bot] Aug 29, 2025
6d66480
refactor: extract duplicated sorting key lambda to improve readability
devin-ai-integration[bot] Sep 3, 2025
c70821e
Update unit_tests/sources/declarative/test_concurrent_declarative_sou…
aaronsteers Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion unit_tests/sources/declarative/test_concurrent_declarative_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3885,7 +3885,7 @@ def test_read_concurrent_declarative_source(
output_data = [
message.record.data for message in _run_read(manifest, _stream_name) if message.record
]
assert output_data == expected_records
assert sorted(output_data, key=lambda x: (x.get("partition", 0), x.get("ABC", 0), x.get("AED", 0))) == sorted(expected_records, key=lambda x: (x.get("partition", 0), x.get("ABC", 0), x.get("AED", 0)))
Copy link

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sorting key logic is duplicated and creates a very long line. Consider extracting the key function to improve readability and reduce duplication: sort_key = lambda x: (x.get(\"partition\", 0), x.get(\"ABC\", 0), x.get(\"AED\", 0)) then use assert sorted(output_data, key=sort_key) == sorted(expected_records, key=sort_key)

Copilot uses AI. Check for mistakes.

mock_retriever.assert_has_calls(expected_calls)


Expand Down
Loading