Skip to content

Conversation

bosper351
Copy link
Contributor

@bosper351 bosper351 commented Sep 10, 2025

Update whenever package and remove unused imports. Currently this blocks using airbyte-cdk and PyAirbyte with Prefect.

Summary by CodeRabbit

  • Chores
    • Updated dependency constraints for the “whenever” library to >=0.7.3,<0.9.0 for compatibility with newer releases.
  • Refactor
    • Cleaned up unused type imports in datetime utilities; no changes to behavior or public API.
  • Notes
    • No user-facing changes expected.

Copy link
Contributor

coderabbitai bot commented Sep 10, 2025

📝 Walkthrough

Walkthrough

The PR removes unused type imports from airbyte_cdk/utils/datetime_helpers.py and widens the whenever dependency range in pyproject.toml to >=0.7.3,<0.9.0. No public APIs or runtime behavior are changed.

Changes

Cohort / File(s) Summary
Import cleanup in datetime helpers
airbyte_cdk/utils/datetime_helpers.py
Removed unused type imports (Optional, Never, LocalDateTime, ZonedDateTime); retained Instant. No functional or API changes.
Dependency version update
pyproject.toml
Updated whenever dependency from ^0.6.16 to >=0.7.3,<0.9.0.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

dependencies, chore

Would you like me to run a quick compatibility scan for whenever versions >=0.7.3 to confirm there are no breaking changes to CI or consumers? wdyt?

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly and concisely reflects the main change: a dependency chore to update the "whenever" package version. It is specific (names the package), succinct, and appropriate for repository history so a teammate can quickly understand the PR's primary purpose.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8682eef and b8c08e3.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • pyproject.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (16)
  • GitHub Check: Manifest Server Docker Image Build
  • GitHub Check: SDM Docker Image Build
  • GitHub Check: MyPy Check
  • GitHub Check: Pytest (All, Python 3.11, Ubuntu)
  • GitHub Check: Pytest (Fast)
  • GitHub Check: Pytest (All, Python 3.10, Ubuntu)
  • GitHub Check: Pytest (All, Python 3.13, Ubuntu)
  • GitHub Check: Pytest (All, Python 3.12, Ubuntu)
  • GitHub Check: preview_docs
  • GitHub Check: Pytest (All, Python 3.11, Ubuntu)
  • GitHub Check: Pytest (All, Python 3.10, Ubuntu)
  • GitHub Check: SDM Docker Image Build
  • GitHub Check: Pytest (All, Python 3.13, Ubuntu)
  • GitHub Check: Manifest Server Docker Image Build
  • GitHub Check: Pytest (All, Python 3.12, Ubuntu)
  • GitHub Check: Pytest (Fast)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
airbyte_cdk/utils/datetime_helpers.py (2)

85-85: Import clean-up LGTM.

Dropping Optional/Never aligns with current annotations; no functionality change. Shall we also remove the unnecessary Union in a few hints in favor of | for consistency, or keep as-is for readability, wdyt?


88-89: Add version constraint comment for Instant usage

Instant.from_timestamp, Instant.from_utc, and py_datetime are confirmed available in whenever 0.7.x–0.8.8; could you add a brief comment linking this import to the matching version constraint in pyproject.toml for future clarity? wdyt?

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ae0e8aa and 8682eef.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • airbyte_cdk/utils/datetime_helpers.py (1 hunks)
  • pyproject.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: Pytest (All, Python 3.13, Ubuntu)
  • GitHub Check: Pytest (Fast)
  • GitHub Check: Pytest (All, Python 3.10, Ubuntu)
  • GitHub Check: Pytest (All, Python 3.11, Ubuntu)
  • GitHub Check: Pytest (All, Python 3.12, Ubuntu)
  • GitHub Check: SDM Docker Image Build
  • GitHub Check: Manifest Server Docker Image Build
🔇 Additional comments (1)
pyproject.toml (1)

96-96: Approve whenever version bump

poetry.lock locks whenever to 0.8.8 (within >=0.7.3,<0.9.0) and no imports of removed symbols (LocalDateTime/ZonedDateTime) remain—looks safe to merge. All set?

@aaronsteers aaronsteers reopened this Sep 17, 2025
@aaronsteers
Copy link
Contributor

aaronsteers commented Sep 17, 2025

/test

PR test job started... Check job output.

✅ Tests passed.

@aaronsteers
Copy link
Contributor

@bosper351 - Thank you for this contribution! 🙏

@aaronsteers aaronsteers merged commit 20d8b3f into airbytehq:main Sep 17, 2025
33 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants